3.6 Naming conventions for variables, constants, functions and classes about nodebestpractices HOT 8 CLOSED

@syzer why not PR it? I can do myself if you're busy

from nodebestpractices.

Great anecdote.

I would vote for removing that - a best practice should provide some practical value, it seems pointless in this case. Let's let it park here for few days and see if there are other thoughts. Case not, let's PR it.

from nodebestpractices.

Also i would change single quoted strings to strings literals:

const config = {
   key: 'value'
}

to

const config = {
   key: `value`
}

It had a performance impact on old versions of node... but that's not an issue anymore.

from nodebestpractices.

here #81 :)

from nodebestpractices.

It had a performance impact on old versions of node... but that's not an issue anymore.

It may not be noticeable, but it's there. It also implies a different semantic. Do you have any references to preferring only ` over the combination with '?

from nodebestpractices.

I can replace ` with ' if you want , however:
template literals allow string interpolation

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

When one add two objects: obj1 + obj2 it works in different way than one might think.
consider this object:

const obj = { valueOf() {return 5}, toString() {return ''} }

now:

typeof (obj + 5) !== typeof `${obj}5`
obj + '42' !== `${obj}42`

When ppl see value, they expect to have a string type, however adding with + will leave good attack vector, or/and potential instability of system.

So using template literals for strings is a good idea. That's why they were introduced in es 2015.

from nodebestpractices.

Although I do see the point you mentioned above, I would prefer using normal strings with single/double quotes by default and template literals only for parts where interpolation is needed. Many style guides also use this pattern, so I think we should really take another look at this change and maybe vote for this.

from nodebestpractices.

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

from nodebestpractices.