newDragSource() does not work about golden-layout HOT 12 CLOSED

I'm willing to help you get this working in the dev branch (which is "my" branch) - i.e. version 2.9.1. Unfortunately, I can't help you with problems in other branches - including master or version 2.6.x.

from golden-layout.

Sure.

from golden-layout.

Hi @pbklink, can you provide an email address so I can ask some questions about rates, timescales and whatnot please?

My email address is on my GitHub home page

from golden-layout.

Thanks! I am literally about to leave the office for a vacation. Can I ping you here when I return in 10 days?

from golden-layout.

But be warned that the dev branch is quite different from 2.6, and migrating will not be trivial.

from golden-layout.

Hi Dan,
I am the author of version 2.x of Golden Layout. I can provide you with support with migrating to or using Golden Layout however I would charge commercial software development rates. Support would cover the existing Golden Layout 2.6 release but not Per's dev branch.

Feel free to use Per's offer of assistance. I will not be offended :) and I am sure that Per will ably assist you.

from golden-layout.

Hi @pbklink, can you provide an email address so I can ask some questions about rates, timescales and whatnot please?

from golden-layout.

Hi @PerBothner is the newDragSource method significantly different between versions 2.6 and 2.9? I don't think it's feasible to try to upgrade to version 2.9 at this point. I've spent weeks getting the 2.6 upgrade to where it is now and all I have left to fix is this drag issue.

from golden-layout.

QQ - does the HTML element need to be visible on screen when newDragSource is called? The items we would like to be drag sources are not visible until the menu is opened (although they do exist in the DOM)

from golden-layout.

is the newDragSource method significantly different between versions 2.6 and 2.9?

Probably. It does look like the implementation of newDragSource is missing or incomplete in 2.9.x. Probably not difficult to fix, but I haven't looked at the code in a while.

I don't think it's feasible to try to upgrade to version 2.9 at this point.

2.9 is a big change. It has some nice new features, but the code and APIs have changed quite a bit, and some things that I don't use a probably broken. (However, if someone needs any missing/broken functionality, I'll work on fixing it.)

from golden-layout.

The issue definitely appears to be related to the fact that these elements are in a hidden menu - if I add a static element to the page and use the same methods to initialise it as a dragSource, it works as expected

from golden-layout.

Finally figured this out. Even though I was making the list-items dragSources, the mouseDown event handler added by golden-layout was being triggered by a label element inside the list-items. There is some logic inside DragSource.js which compares the event.target for the mouseDown event to the dragSource element, and obviously they were not the same element.

I fixed it by making the labels drag sources instead of the list items

from golden-layout.