Giter VIP home page Giter VIP logo

Comments (2)

GolanLevy avatar GolanLevy commented on September 20, 2024

Hey Paul,

The loading does work (I've just checked).
Just to make sure we are talking on the same thing, here is what I tried:
Load demo>change one of the colors of the speaker>save>load the demo audio with the downloaded file> see that the color is similar to the saved color.

Note that the colors are handled outside the regions' plugin and are being initialized here.
A region gets its color here
The colors are saved under each of the 'speaker' entries in the json file and so they are being loaded from it.
The appropriate thing to do is to put it in some kind of metadata object, parallel to the 'monologues' entry, so we won't have so many duplicates.

It will be great if you will make this separation.
Please consider two issues:

  1. backwards compatibility (unless you think it is unnecessary and then I will consider it with my team)
  2. synchronizing colors between the same speaker in different files.

from gecko.

PaulLerner avatar PaulLerner commented on September 20, 2024

Hi Golan,
Thank you for your answer, sorry about that, I'm not sure why I thought that color loading was not efficient.
Thanks for the info !

from gecko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.