Duplication of ID in Web API about gosdm630 HOT 3 CLOSED

@TheCount I'm recently helping @gonium with maintaining this repo. I've also used the UniqueId for topic generation in the mqtt client for consistency. Do you see need for further changes?

from gosdm630.

Personally, no, I can live with the status quo.

The issue here is that it would be sufficient (thus more minimalistic, thus cleaner) to have the ID merely identify the bus, not the instrument.

The thing is, software using the output of gosdm would need an extra operation to generate a unique instrument ID then. A perfectly reasonable requirement for software you are currently developing yourself; more onerous for legacy or third-party software with limited JSON-interpretation capabilities.

from gosdm630.

The issue here is that it would be sufficient (thus more minimalistic, thus cleaner) to have the ID merely identify the bus, not the instrument.

Interesting point, i.e. in case of multiple modbus adapters?

Its still debatable then if the physical modbus layout (adapter, device numbers) should equal the logical API view.

from gosdm630.