plot: make Rect work the same way as image.Rectangle about plot HOT 6 CLOSED

Also possibly consider Rect -> Rectangle for similar though less pressing reasons.

from plot.

I choose min and size because it elides the min>max issue that the other
representation has... though I guess that assume size is non-negative.

On Wed, Feb 11, 2015, 18:47 Dan Kortschak [email protected] wrote:

Also possibly consider Rect -> Rectangle for similar though less pressing
reasons.

—
Reply to this email directly or view it on GitHub
#13 (comment).

from plot.

I figured that was the reason.

though I guess that assume size is non-negative.

If we were in uint* space that would be OK. I think the comment in image covers this: if Min > Max we don't guarantee anything.

from plot.

I'm OK with the change. Consistency is good. But I'm not convinced there is
much more of an advantage than that. Is there?

On Wed, Feb 11, 2015, 18:55 Dan Kortschak [email protected] wrote:

I figured that was the reason.

though I guess that assume size is non-negative.

If we were in uint* space that would be OK. I think the comment in image
covers this: if Min > Max we don't guarantee anything.

—
Reply to this email directly or view it on GitHub
#13 (comment).

from plot.

None.

from plot.

consistency with image.Rectangle is good.
"self-consistency" and good "code flow" is even better :)
as hinted above, I always second guess myself (is Min or Max the method? or the field?)
count me as +1 on this.

from plot.