Comments (3)
Thank you for catching this, Sadegh!
Indeed, there was an issue with KMP's handling of a '-1' node that we initially tried to circumvent.
We now have a patch for this in #69, and at least on 2,000 randomly generated strings, the output of KMP matches the output of the naïve string matcher.
The patch will be merged (and data regenerated) during the next day or two. Thanks!
from clrs.
Hi Sadegh, this should now be patched!
Could you verify this on your end (and close the issue if so)? Thanks again for spotting it.
from clrs.
Hi Petar, yes it's fixed now. Thanks for the patch.
from clrs.
Related Issues (14)
- Is the paper still available? HOT 3
- Hint `A_t` in SCC HOT 2
- Why no directed graph for FloydWarshall, Dijkstra, BFS and BellmanFord HOT 2
- Issue with distribution of undirected graphs HOT 2
- What does DFS output result mean ? HOT 1
- Repetition of indexes in pred
- Update of PyPI version
- Tarjan's strongly connected components algorithm
- Sampling bug on undirected weighted graphs HOT 2
- More input signals for evaluation HOT 9
- tensorflow-macos and tensorflow-metal
- Inability to reproduce paper results HOT 5
- Problems with jax HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clrs.