Giter VIP home page Giter VIP logo

Comments (5)

sethvargo avatar sethvargo commented on July 4, 2024 1

I should probably write an extension to https://github.com/google-github-actions/actions-utils/blob/main/src/csv.ts#L25 that handles newline-separation and trims leading whitespace.

from deploy-cloudrun.

sethvargo avatar sethvargo commented on July 4, 2024

Interesting - we have logic to convert newlines to commas, but that doesn't appear to be working for some reason.

from deploy-cloudrun.

gustavovalverde avatar gustavovalverde commented on July 4, 2024

Just a follow up as this is not fix in the latest version even with #312

from deploy-cloudrun.

sethvargo avatar sethvargo commented on July 4, 2024

The latest version supports multi-line parsing and CSV parsing. It does not support multi-line parsing where lines end in CSVs. It's been fixed in the upstream libraries.

The examples above should both work with the latest release:

env_vars: |
  RELEASEMODE=development
  NODE_ENV=development
  PORT=4000
  DB_DATABASE=database_name
env_vars: 'RELEASEMODE=development,NODE_ENV=development,PORT=4000,DB_DATABASE=database_name'

The following will not work until the next release:

env_vars: |
  RELEASEMODE=development,
  NODE_ENV=development,
  PORT=4000,
  DB_DATABASE=database_name'

from deploy-cloudrun.

gustavovalverde avatar gustavovalverde commented on July 4, 2024

Oh, great, thank you.

from deploy-cloudrun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.