Giter VIP home page Giter VIP logo

Comments (4)

averikitsch avatar averikitsch commented on July 23, 2024 2

Thank you for submitting this request. I am working on this feature; however the maintainers are currently reviewing the implementation of this action.

from deploy-cloudrun.

zrosenbauer avatar zrosenbauer commented on July 23, 2024

This should be pretty quick to add unless I'm mistaken:
https://github.com/google-github-actions/deploy-cloudrun/blob/main/src/service.ts#L92

// If name is provided, set or override
if (opts.revision-name) {
  request.status.latestReadyRevisionName = opts.revision-name;
  request.status.latestCreatedRevisionName = opts.revision-name;

  // probably need to support traffic also....
  // look into how revision-suffix is created in cli
}

If this is also something the maintainers are willing to accept as a PR, I'd be happy to attempt add it in.

from deploy-cloudrun.

rrdelaney avatar rrdelaney commented on July 23, 2024

Thank you for working on this feature! Would this also allow us to specify custom tags as an input?

from deploy-cloudrun.

zrosenbauer avatar zrosenbauer commented on July 23, 2024

I should be a bit easier IMO once its moved to the gcloud CLI #42

from deploy-cloudrun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.