Comments (4)
qwandor
commented on July 27, 2024
If you omit the 0x prefix then the number is interpreted as decimal. That is intentional, as sometimes it gets dumped that way in some logs or debuggers, but adding a comment explaining the behaviour seems like a good idea.
from aarch64-esr-decoder.
thass0
commented on July 27, 2024
Yes, I think adding a more detailed error message here (and in the other cases where parsing fails) would really improve the user experience.
Looks like the ParseIntError enum returned by the parse_number function contains the information needed to distinguish errors.
I could add a more verbose error message and PR later if you want.
from aarch64-esr-decoder.
qwandor
commented on July 27, 2024
@thass0 Please take a look at #86.
from aarch64-esr-decoder.
thass0
commented on July 27, 2024
That looks great, thanks for the fix 😀
from aarch64-esr-decoder.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aarch64-esr-decoder.