Comments (11)
I don't know if adding custom composables of already existing ones is a good idea. That would require alot of maintanance in the future. If Scaffold
is changed, so will InsetAwareScaffold
have to change.
Wouldn't a simple modifier that applies the insets to the any Composable? Something like .padding(WindowInsets)
or applyWindowInsets()
from accompanist.
If
Scaffold
is changed, so willInsetAwareScaffold
have to change.
Compose’s API is now API stable, so there won’t be any API changes. Also, this library isn’t designed to live forever.
Wouldn't a simple modifier that applies the insets to the any Composable? Something like
.padding(WindowInsets)
orapplyWindowInsets()
We already have that: https://google.github.io/accompanist/insets/
from accompanist.
From what I remember in Flutter, only the Scaffold
was insets aware, and it passed those insets to its children. So maybe that's how it should be done in here as well?
from accompanist.
Sure, but we're not copying Flutter, or being limited to what Flutter provides.
from accompanist.
I have made a PR for this.
from accompanist.
Please no, that feels like adding unnecessary bloat (a little rude, excuse me). I don't want to have many theme / styles / layout implementations, that's a past thing which in my opinion shouldn't be added (remember multiple application themes, in my opinion there's just has to be one - DayNight and that's it etc...)
from accompanist.
Please no, that feels like adding unnecessary bloat (a little rude, excuse me).
I get not wanting to bloat the main library, but this would be in an optional insets-layouts
library (if we did it).
from accompanist.
from accompanist.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
from accompanist.
The issue is still relevant.
from accompanist.
Oh, thank you!
from accompanist.
Related Issues (20)
- [WebView] Question about backwards writes HOT 5
- Vector animation is broken with newer libraries HOT 5
- False positive deprecation message on pagerTabIndicatorOffset variant HOT 2
- onPermissionsResult isn't triggered on POST_NOTIFICATIONS permission request (API 33). HOT 2
- [Test Harness] Deprecate with replacement of `DeviceConfigurationOverride`
- Incorrect deprecation of pagerTabIndicatorOffset HOT 2
- [Permissions] Gradle update crashing permission request and the app HOT 8
- Crash when using ProgressIndicator with `accompanist-permissions` 0.34.0 HOT 1
- [Navigation Material] Crash in BottomSheetNavigator when user goes back HOT 3
- [Navigation Material] Status bar not scrimmed when bottom sheet is shown HOT 1
- [LazyColumn] scroll observation scope does not exist HOT 3
- [Feature request] LazyTable with nested scrolling support HOT 1
- [Navigation Material] Edge to edge jumping bug when migrating from 1.1.2 to 1.2.0. HOT 1
- [Navigation Material] BackHandler is not triggered after Activity stop+start HOT 1
- [Navigation Material] DisposableEffect onDispose is not called at the right time for bottom sheet HOT 1
- [Navigation Material] Add deprecated to main README
- [Adaptive]
- accompanist-drawablepainter: PictureDrawable doesn't scale HOT 1
- BottomSheetNavigator#NullPointerException HOT 1
- [Webview] fit parent width issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accompanist.