Giter VIP home page Giter VIP logo

Comments (7)

ndegwamartin avatar ndegwamartin commented on July 20, 2024 3

One improvement I can think of is removing a.resourceType = b.resourceType clause in JOIN statement as we are filtering resourceType using WHERE clause. But not sure if this is feasible or even if it's gonna improve the performance

Removing this does improve the performance as well, executing the query in milliseconds cc LZRS

from android-fhir.

MJ1998 avatar MJ1998 commented on July 20, 2024 2

One improvement I can think of is removing a.resourceType = b.resourceType clause in JOIN statement as we are filtering resourceType using WHERE clause.
But not sure if this is feasible or even if it's gonna improve the performance

from android-fhir.

LZRS avatar LZRS commented on July 20, 2024

@aditya-07 @MJ1998 here's the ticket about the issue on performance we're experiencing

from android-fhir.

MJ1998 avatar MJ1998 commented on July 20, 2024

Can you tell me how does it perform without filter of active Patients ?

from android-fhir.

ndegwamartin avatar ndegwamartin commented on July 20, 2024

It is worth noting that the above latency difference is observable even on non-device sqlite db browsers like SQLiteStudio.

from android-fhir.

ndegwamartin avatar ndegwamartin commented on July 20, 2024

Can you tell me how does it perform without filter of active Patients ?

Removing the subquery that performs this filter has no impact on the performance.

from android-fhir.

jingtang10 avatar jingtang10 commented on July 20, 2024

thank you very much for catching this @LZRS! very happy for the improvement in @MJ1998 's pr.

just one comment for clarification and potential future work: #2553 (comment)

from android-fhir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.