Comments (7)
One improvement I can think of is removing
a.resourceType = b.resourceType
clause in JOIN statement as we are filtering resourceType using WHERE clause. But not sure if this is feasible or even if it's gonna improve the performance
Removing this does improve the performance as well, executing the query in milliseconds cc LZRS
from android-fhir.
One improvement I can think of is removing a.resourceType = b.resourceType
clause in JOIN statement as we are filtering resourceType using WHERE clause.
But not sure if this is feasible or even if it's gonna improve the performance
from android-fhir.
@aditya-07 @MJ1998 here's the ticket about the issue on performance we're experiencing
from android-fhir.
Can you tell me how does it perform without filter of active Patients ?
from android-fhir.
It is worth noting that the above latency difference is observable even on non-device sqlite db browsers like SQLiteStudio.
from android-fhir.
Can you tell me how does it perform without filter of active Patients ?
Removing the subquery that performs this filter has no impact on the performance.
from android-fhir.
thank you very much for catching this @LZRS! very happy for the improvement in @MJ1998 's pr.
just one comment for clarification and potential future work: #2553 (comment)
from android-fhir.
Related Issues (20)
- Improve initial load for calculated-expression HOT 1
- Open choice missing string value HOT 5
- Improve Readability and Maintainability of Data Purge Function (purge()) HOT 1
- Expose an interface to db.withtransaction through FhirEngine
- Do you think it would be important to handle [WorkInfo.State#BLOCKED](https://developer.android.com/reference/androidx/work/WorkInfo.State#BLOCKED) status or defaulting to error would just be enough?
- support for UploadRequestGeneratorMode.UrlRequest in UploadStrategy (?) to support OpenMRS as FHIR Backend HOT 1
- refactor - Move Search Logic from Search.execute() to FhirEngine.search() HOT 2
- erroreneous docs - search method documentation
- 'SELECT' queries sometimes take too long to run HOT 6
- Custom Search Parameter does not Consider in x-fhir-query HOT 1
- Wrap FHIREngine API calls with "withContext(Dispatcher.IO) {}"
- Sync fails with 'too many SQL variables' in select HOT 3
- SQLite crashes with 'Expression tree is too large (maximum depth 1000)' HOT 3
- Update the repeatedGroup ui. HOT 3
- Add Distinct in SQL query instead of kotlin function in search query
- Previous button shows up on the first page
- Cookie Support in Headers through networkConfiguration HOT 7
- Snapshot Packages are not published or visiblie HOT 5
- Update documentation for custom ui components
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-fhir.