Comments (5)
I'm not sure that we actually want to do this, because it only applies to zelos. The dropdown field handles this by using a special constant in the zelos renderer sets to true. We could use the same flag to trigger the functionality in the slider field, but it sucks that the constant is prefixed with FIELD_DROPDOWN
, and not something more generic.
from blockly-samples.
This happens in all the renderers, not just Zelos, because all the renderers use the block's color as the background for the slider div. So in this case there is no need to use the FIELD_DROPDOWN_COLOURED_DIV
value. We could have chosen to do so in the beginning if we wanted the slider to be white in thrasos and colorful in zelos, to match the dropdown field, but that would be a behavior change since currently it always has a colored background.
from blockly-samples.
I think what I was concerned about is that in other renderers, the shadow block (and its color) are actually shown. So I think it makes sense to make the dropdown div the color of the shadow block in those cases:
As opposed to zelos, which does not show the shadow block if the only element of the block is the field:
Where it definitely does make sense to use the color of the parent block.
I guess the question is whether you think it makes sense in the first case for the background of the slider to be green or not.
from blockly-samples.
Huh. Since most of the shadow blocks are numbers I never noticed they have their own colors haha. I thought they were all gray...
In that case, I think you're right that we shouldn't change this. In Zelos you cannot tell the difference between a shadow block and a real block visually, so the shadow block should behave the same as the real block IMO. If it would be blue when you drop a real block in, it should probably be blue before that as well. That seems least surprising.
The original screenshot looks incorrect, but it would be the exact same behavior if the slider block is a "real" block instead of a shadow, so I think that's more of a problem with zelos in general than this specific behavior.
wdyt? i'm fine to just close this if you agree.
from blockly-samples.
Agree, closing.
from blockly-samples.
Related Issues (20)
- Update field colour readme to explain that the developer must load a message file/set a locale HOT 2
- Consider excluding test-only changes from lerna release
- Update multiline text readme to include the information currently on devsite HOT 1
- Merge `blocks_for_fields` into `master` HOT 1
- Error: Property 'decoratePreviewerWithDynamicConnections' does not exist on type 'typeof import ("("/home/user/Documents/blockly/node_modules/@blockly/block-dynamic-connection/dist/index")'. HOT 1
- Save/load/delete multiple blocks
- Block factory: add generator stubs
- Block factory: adding code headers
- Block factory: import plugin fields HOT 1
- Block factory: backwards compatibility
- Block factory: redirect at top of old block factory
- Block factory: redirect back to old block factory
- eslint config disallows CONSTANT_CASE HOT 1
- Block factory: add shadow blocks to inputs HOT 1
- Resetting the workspace state when entering data in num and funcs HOT 5
- Make it so that the backpack is compatible with other types besides blocks HOT 1
- Update context menu codelab (scope + events)
- Content-highlight doesn't update for workspace comment move events
- typed-variable-modal plugin is not on plugins index page HOT 7
- Toolbox section of demos page is broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blockly-samples.