strange error when building cdep sample: CMAKE_SYSTEM_VERSION is 1 about cdep HOT 2 CLOSED

Hi from the peanut gallery.

The problem comes from this: android.toolchain.cmake line 42
Inhibit all of CMake's own NDK handling code.
set(CMAKE_SYSTEM_VERSION 1)

When using the toolchain that is shipped with the ndk there's a specific check for CMAKE_SYSTEM_VERSION greater than 22 at line 46 of the generated cdep-dependencies-config.cmake
if(CMAKE_SYSTEM_NAME STREQUAL "Android")
if(CMAKE_SYSTEM_VERSION GREATER 22)
...
else()
message (FATAL_ERROR "") <-- that's the failure you're seeing.

If you use a system cmake or one that doesn't use android.toolchain.cmake then the CMAKE_SYSTEM_VERSION will be set correctly and there's no need for the workaround you're deleting here.

CMAKE_SYSTEM_VERSION is a correct check to ensure that the platform OS being targeted is at a specific platform. It is populated by buildSystemTargetPlatform. I'd venture this is a working as designed bug.
The only real suggestion I'd have is to place a new variable in android.toolchain.cmake that doesn't conflict with CMAKE_SYSTEM_VERSION and cdep can check both? This would eliminate the need for the workaround and mask the issue to users.

from cdep.

yeah, that sounds correct. thank you!

from cdep.