Spread operator breaking Node LTS about closure-compiler-js HOT 9 CLOSED

Fixed here. We'll try to target the LTS release (currently 4.5) from now-on-in.

from closure-compiler-js.

The JS is created with GWT which I'm pretty sure only outputs ES5. Are you sure you're seeing a spread operator in the compiler?

from closure-compiler-js.

There error I'm seeing is a node failure:

  out.warnings = [...out.warnings];
                  ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)

And checking compile.js in the node_modules folder, it's definitely there.

const jscomp = require('./jscomp.js');

module.exports = function(flags) {
  const clone = {};
  for (const k in flags) {
    clone[k] = flags[k];
  }
  const out = jscomp(clone);

  // hide weird GWT internals
  out.warnings = [...out.warnings];
  out.errors = [...out.errors];

  return out;
};

from closure-compiler-js.

@MatrixFrog

from closure-compiler-js.

Oh, gotcha. It's not in the gwt-compiled JS, but the small amount of hand-written JS. @samthor what do you think about taking out the ... until the LTS version of node supports it?

from closure-compiler-js.

We can do that. I think there may be other reasons we don't support LTS though. I'm not really up to speed on what it does or doesn't support - I'm surprised it seems to support const and let?

@tquetano-r7 can you send a PR? Otw I'll get to it soon.

from closure-compiler-js.

Sorry for the late response, appreciate you jumping on it so quickly!

from closure-compiler-js.

Appreciate you guys fixing this, but is there any chance it can be released? Fresh install of the NPM package still points to 20160822.

from closure-compiler-js.

I've published 20160822.0.1 which has the fix.

from closure-compiler-js.