Comments (2)
Hi @goj,
This particular case is actually working as intended.
Note that the feature only works for bindings that depend on optional bindings and/or multibindings. In particular, Dagger will re-resolve a binding in a component if there is a contribution to the optional binding or multibinding in that component.
For example, with multibindings you can have something like this:
@Module
interface ParentModule {
@Multibinds
Set<Bar> setOfBar();
@Provides
Foo provideFoo(Set<Bar> setOfBar) { ... }
}
@Module
interface ChildModule {
@Provides
@IntoSet
Bar provideBarIntoSet() { ... }
}
public void main() {
// The set is empty in this Foo
Foo parentFoo = parentComponent.getFoo();
// The set has one element in this Foo
Foo childFoo = childComponent.getFoo();
}
I do agree that the behavior is a bit confusing since the contents of the optional or multibinding can change depending on which component you request it from, but that's how they were designed and also their main benefit.
Also note that #2085 is different and that actually is a bug. In that case the issue was that we were re-resolving for non-optional/multibindings.
from dagger.
It's a bug. Adding a scoping annotations (e.g. making
JudgmentalCoffee
a@Singleton
in the example above) changes what gets injected. For a big projects and long injection chains this may lead to a very surprising results
Sorry, forgot to comment on this in my previous post.
Yes, scoping JudgmentalCoffee
with @Singleton
means that it will be locked into the ParentComponent
and so it would no longer pick of the Sugar
you've provided in your ChildComponent
(i.e. the Optional<Sugar>
it injects will be empty).
This complexity is part of the trade-off of using optional/multibindings, and I would advise to use them as little as possible and only when absolutely needed.
from dagger.
Related Issues (20)
- error: [Hilt] Expected @AndroidEntryPoint to have a value HOT 3
- @IntoSet analog for injectable classes HOT 3
- Hilt Generated Code having not used code? HOT 2
- [Dagger-Hilt] Can't get viewModel in composable by Hilt HOT 1
- Why does Provides in a Companion Object work? HOT 6
- Update Dagger guava dependency to address CVE-2023-2976 HOT 2
- Add KMP support for @HiltViewModel annotation HOT 2
- Dagger resolution and dynamic feature module HOT 1
- Feature request: Manually regenerate application component HOT 1
- Using TestContainer.com HOT 2
- Detect dependency cycles containing Lazy or Provider during the compilation time HOT 6
- error when ksp.useKSP2=true HOT 2
- Suppress annotation on @Inject is not honored on the Factory HOT 1
- [KSP2] Dagger and Hilt incompatibility with KSP2 HOT 2
- [KSP2] NullPointerException: null cannot be cast to non-null type androidx.room.compiler.processing.XType HOT 1
- App crashing with NPE for some classes when Lazy Class Key is used HOT 6
- OutOfMemoryError with Maven HOT 1
- DaggerAppComponent not creating in the version 2.51.1 HOT 3
- java.lang.ClassNotFoundException: dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacBasicAnnotationProcessor. Hilt 2.49+ HOT 1
- how to manually generate module HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagger.