Refaster includes fully qualified reference to the `@AfterTemplate` to local variable inside the template about error-prone HOT 4 CLOSED

@Stephan202 ah thanks for the clarification, i was not aware of that (yet) :)

Moving my issue report to openrewrite/rewrite-templating#90 then, assuming this issue never happened with the implementation in this repository (?)

from error-prone.

Hey @Philzen! It looks like you're using OpenRewrite's Refaster-to-recipe feature. OpenRewrite's implementation supports a subset of Refaster annotations, completely independently from the official Refaster implementation provided by Error Prone. I think you meant to file this issue against the openrewrite/rewrite-templating project.

(CC @timtebeek :).)

from error-prone.

@Stephan202 thanks a lot for the confirmation!

from error-prone.

assuming this issue never happened with the implementation in this repository (?)

I locally tested that to be sure (we have a project with a test framework for Refaster rules), and I can confirm that with stock Error Prone this rule behaves correctly.

With it, this code:

void testMigrateAssertEqualsFloatArrayDelta() {
  float[] actual = {0F};
  float[] expected = {1F};
  float delta = 0;
  Assert.assertEquals(actual, expected, delta);
}

Is rewritten to:

void testMigrateAssertEqualsFloatArrayDelta() {
  float[] actual = {0F};
  float[] expected = {1F};
  float delta = 0;
  Assertions.assertAll(
      () -> {
        Assertions.assertEquals(
            expected.length, actual.length, "Arrays don\'t have the same size.");
        for (int i = 0; i < actual.length; i++) {
          Assertions.assertEquals(expected[i], actual[i], delta);
        }   
      }); 
}

(I see that Error Prone also unnecessarily escapes the single quote. In PicnicSupermarket/error-prone-support#1138 I worked around a similar issue. I just noticed that Error Prone also has a utility method for this, but apparently the Refaster code path doesn't use it. @cushon WDYT of upstreaming a more efficient implementation? Happy to open a PR.)

from error-prone.