Giter VIP home page Giter VIP logo

Comments (4)

cslee00 avatar cslee00 commented on May 17, 2024 1

Thanks. To be clear, this isn't about modularizing the code - rather reserving the module name to avoid downstream challenges when Flogger is modularized.

Currently, without the Automatic-Module-Name manifest entry, when Flogger is used in a modularized application the JVM will automagically determine the module name from the JAR filename (ugh). This will cause downstream problems for consumers of Flogger, particularly transitive dependencies on Flogger, when it's released as a proper module due to the module name changing. Adding Automatic-Module-Name reserves the module name now for future compatibility.

from flogger.

cslee00 avatar cslee00 commented on May 17, 2024

Relevant context around use of Automatic-Module-Name: http://branchandbound.net/blog/java/2017/12/automatic-module-name/
https://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

from flogger.

hagbard avatar hagbard commented on May 17, 2024

Thanks, I'll have a look. However I don't make any promises, especially since I think Flogger might need so refactoring (a big task) before it adheres to the rules about modules (we don't have "closed" packages in the project and different artifacts own code in the same package). We might have to end up building a single combined JAR with fronted and backend code for use with modules (it's all do do with the fact that the core code is Java6 compatible while the JDK backend code is Java7+).

from flogger.

ronshapiro avatar ronshapiro commented on May 17, 2024

For reference: #22 highlights the JPMS issues

from flogger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.