Giter VIP home page Giter VIP logo

Comments (10)

pmatteo1998 avatar pmatteo1998 commented on August 18, 2024

i solved my self the issues , basically i put roboto's ttf into the asset folder and edited font manifest.
i think that this must mentioned in the linux section to get at least the demo up & running correctly.

from flutter-desktop-embedding.

stuartmorgan avatar stuartmorgan commented on August 18, 2024

@awdavies Can you take a look at this?

Before we add Roboto to the pubspec, it would be good to understand why this isn't an issue on macOS (even non-corp). Is Material choosing San Francisco as the font on macOS? If so, is that something we can depend on, or an accident of iOS detection?

from flutter-desktop-embedding.

awdavies avatar awdavies commented on August 18, 2024

@pmatteo1998 Can you link the versions of flutter and the engine so I can take a look?

Thanks.

from flutter-desktop-embedding.

pmatteo1998 avatar pmatteo1998 commented on August 18, 2024

i don't know how to get the engine version but i'm using the version forked with my github account so i think you can get it from there

from flutter-desktop-embedding.

stuartmorgan avatar stuartmorgan commented on August 18, 2024

Looks like the engine hash is 765b7d46b78fedbd94ed95c94b74e88c0a7fc758
And what's the hash of your Flutter tree?

Did you follow the instructions at https://github.com/google/flutter-desktop-embedding/tree/master/linux to ensure that you're using compatible versions of Flutter and the engine?

from flutter-desktop-embedding.

pmatteo1998 avatar pmatteo1998 commented on August 18, 2024

yes,the command:
git checkout $(cat ../flutter/bin/internal/engine.version)
gives me:
HEAD is now at 06afdfe54... Ensure that application termination callbacks are serviced on the runner thread. (#5247)

from flutter-desktop-embedding.

stuartmorgan avatar stuartmorgan commented on August 18, 2024

Okay, so you're not at the head of your fork of the engine tree then. Did you do the build with 06afdfe54..., or with 765b7d46b78fedbd94ed95c94b74e88c0a7fc758?

We still need the hash of your Flutter tree as well.

from flutter-desktop-embedding.

stuartmorgan avatar stuartmorgan commented on August 18, 2024

Is Material choosing San Francisco as the font on macOS? If so, is that something we can depend on, or an accident of iOS detection?

I haven't verified by live debugging, but from some source inspection it looks like the answer to this part is here:
https://github.com/flutter/flutter/blob/2958d7d0fce2876cfa1327c89e7ef859dbd6d0a3/packages/flutter/lib/src/foundation/platform.dart#L33
(In general we'll need to figure out how to handle this on desktop; what's there happens to work for us so far, but Windows will be an issue.)

I'm not sure if we can reasonably conditionally bundle Roboto on non-macOS; we may have to just always bundle it. We should see how Flutter handles that for iOS vs Android.

from flutter-desktop-embedding.

pmatteo1998 avatar pmatteo1998 commented on August 18, 2024

Roboto is already present in android at system level so the app do not need to import it.
for ios flutter use a custom font which bundle strict into the asset output.

from flutter-desktop-embedding.

stuartmorgan avatar stuartmorgan commented on August 18, 2024

I wasn't able to repro this, but expect that #82 fixed it. If you can still repro with latest trunk, please let me know.

from flutter-desktop-embedding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.