Comments (3)
An alternative we discussed is updating the protocol to remove this option and thus making it simpler. This was a "you would not need configuration" attempt, but one that would rely on smart key (re)generation, requiring knowledge of all prior public keys.
from glome.
The more I think about this, the more I come to the conclusion that the implementation is correct. The protocol specifies
7-bit service key prefix and message tag prefix (of any length, including 0)
[...]
if no index found [the service key prefix] will be matched with the public key
which is, granted, not very precise. But the 7 least significant bits of a value stored in little-endian format can ostensibly be called a prefix. More elegant would have been to take the 7 least significant bits of the most significant byte (exploiting the reserved high-bit of x25519 public keys), but I don't think we'd gain much from changing the implementation that way. If you agree, I'd say we adjust the protocol spec to say what the implementation does and close this issue.
from glome.
I think you are correct. In retrospect I confused myself. Because the top bit is always zero in the public key anyway, I think this actually makes more sense than a bit shift.
from glome.
Related Issues (20)
- Key material should have a consistent and safe format HOT 2
- glome-login config file cannot be 'special' HOT 1
- glome-login leaving an extra newline in the input buffer before returning? HOT 2
- CLI should handle tags as base64 instead of hex
- Support more fleet-wide settings in the config file HOT 5
- GLOME Login assumes that challenge is an URL HOT 1
- More user-friendly landing README HOT 1
- PAM module arguments naming is inconsistent with the config HOT 2
- OpenSSL's HMAC API is deprecated in 3.x
- Build fails on NixOS
- Github Actions not triggering on PR HOT 1
- Implement RFD001 (GLOME Login v2)
- Implement support for v2 in Go and Python (keeping v1 support to grant users a transition period).
- Switch CLI, C library and binary to v2, dropping v1 support HOT 1
- Document the new protocol.
- Drop v1 support in Go and Python. HOT 1
- Improve documentation of `glome.h`
- Add Go GLOME config file parsing
- golang ParseURLResponse function does not handle URLs correctly HOT 1
- MVP: Login PAM module plus signing CLI HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glome.