Comments (6)
Pinging @sbarzowski as requested.
from go-jsonnet.
Specifically, camh wants to return an error from a NativeCallback and there's only the regular error return there. I'm not sure if it even has support for RuntimeError or whether it just treats everything as an internal error.
from go-jsonnet.
Ah. It's a mistake, thanks for finding it. The idea was to always wrap this error as a runtime error. (And if you really want to crash with an internal error you can just panic - this will also cause a stack trace to be included).
Here's a pull request which fixes that: #165 (no tests at the moment, I'll try to add some later).
from go-jsonnet.
LGTM. I wrote a test if you want it, here: camh-@4ff0363
from go-jsonnet.
@camh- Cool! Of course I want it :-). Please send a pull request (directly to google/go-jsonnet).
from go-jsonnet.
Pull request #166 sent. It is based on master so the tests will be failing until #165 is merged.
from go-jsonnet.
Related Issues (20)
- Is `v0.20.0` the latest release? HOT 2
- add unit tests for `add_plus_object.go , enforce_comment_style.go and enforce_max_blanck_lines.go` HOT 1
- jsonnet-lint missing std.all and std.any
- jsonnet-lint missing std.reverse
- jsonnet-lint missing std.objectKeysValues HOT 1
- parseYaml panics when passed empty string
- gazelle naming convention changes
- Decimal number displayed differently
- Need help building the c-bindings
- jsonnetfmt cli tool could support a canonical mode
- [Question] Parser package, children function
- std.splitLimitR is missing from go-jsonnet
- Support for stdlib context (cancellation / timeouts)
- Concurrency safe `FileImporter` HOT 6
- Interest for import toml ? HOT 1
- Buggy field visibility handling in`objectHas` in Go impl
- escapeStringXml vs escapeStringXML
- `--jpath` does not support multiple search paths HOT 4
- std.parseYaml wraps result in an array when string values contain HOT 3
- Question: Any chance a more recent stdlib could be pulled in? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-jsonnet.