The Android client should allow editing the issuer (what looks like the title of each

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Should allow editing issuer about google-authenticator-android HOT 7 OPEN

google commented on July 28, 2024 1

Should allow editing issuer

from google-authenticator-android.

Comments (7)

capi commented on July 28, 2024

I am not entirely sure if I understand what you want, but you already can edit the title of each row by long-pressing the entry and selecting "Rename" from the context menu.

from google-authenticator-android.

wernight commented on July 28, 2024

You can edit the title not the issuer. Issuer is what is above the OTP.

from google-authenticator-android.

capi commented on July 28, 2024

Oh sorry, I always added all keys via manual setup and not via QR, so this field seems to be empty and I only see the title.

from google-authenticator-android.

edmorley commented on July 28, 2024

There are quite a few providers who are not setting their issuer correctly [1], and without this feature there's no way to add it back if without manually manipulating the otpauth:// strings.

Also for manually added keys there's no way to add it in retrospectively.

[1] ie they use:
otpauth://totp/[email protected]?secret=FOO
rather than:
otpauth://totp/ISSUER:[email protected]?secret=FOO&issuer=ISSUER

from google-authenticator-android.

ocdtrekkie commented on July 28, 2024

I just experienced this yesterday, WildStar (recently gone free-to-play) supports OTP, but doesn't set their issuer at all.

from google-authenticator-android.

edmorley commented on July 28, 2024

I guess it either needs an additional context menu item (and the existing one be renamed from "Rename" to "Rename username") like this:

google-authenticator-android/AuthenticatorApp/src/main/java/com/google/android/apps/authenticator/AuthenticatorActivity.java

Lines 685 to 698 in d1b53c2

 case RENAME_ID: 

 final Context context = this; // final so listener can see value 

 final View frame = getLayoutInflater().inflate(R.layout.rename, 

 (ViewGroup) findViewById(R.id.rename_root)); 

 final EditText nameEdit = (EditText) frame.findViewById(R.id.rename_edittext); 

 nameEdit.setText(user); 

 new AlertDialog.Builder(this) 

 .setTitle(String.format(getString(R.string.rename_message), user)) 

 .setView(frame) 

 .setPositiveButton(R.string.submit, 

 this.getRenameClickListener(context, user, nameEdit)) 

 .setNegativeButton(R.string.cancel, null) 

 .show(); 

 return true;

google-authenticator-android/AuthenticatorApp/src/main/java/com/google/android/apps/authenticator/AuthenticatorActivity.java

Lines 741 to 758 in d1b53c2

 private DialogInterface.OnClickListener getRenameClickListener(final Context context, 

 final String user, final EditText nameEdit) { 

 return new DialogInterface.OnClickListener() { 

 @Override 

 public void onClick(DialogInterface dialog, int whichButton) { 

 String newName = nameEdit.getText().toString(); 

 if (newName != user) { 

 if (mAccountDb.nameExists(newName)) { 

 Toast.makeText(context, R.string.error_exists, Toast.LENGTH_LONG).show(); 

 } else { 

 saveSecretAndRefreshUserList(newName, 

 mAccountDb.getSecret(user), user, mAccountDb.getType(user), 

 mAccountDb.getCounter(user)); 

 } 

 } 

 } 

 }; 

 }

...or else converting the existing rename to a split two input field control.

Though the wiki seems to imply this project is behind the "official" Google authenticator app, so not sure what a PR here would achieve :-(

from google-authenticator-android.

ocdtrekkie commented on July 28, 2024

@edmorley The "official" Google app is no longer open source. It's now a proprietary app (and for that reason, I'd personally recommend using it, but whatever). This app is fully functional, but no, changes to this will not make it into the Play Store version. You'd need to compile it yourself.

from google-authenticator-android.

Should allow editing issuer about google-authenticator-android HOT 7 OPEN

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	case RENAME_ID:
	final Context context = this; // final so listener can see value
	final View frame = getLayoutInflater().inflate(R.layout.rename,
	(ViewGroup) findViewById(R.id.rename_root));
	final EditText nameEdit = (EditText) frame.findViewById(R.id.rename_edittext);
	nameEdit.setText(user);
	new AlertDialog.Builder(this)
	.setTitle(String.format(getString(R.string.rename_message), user))
	.setView(frame)
	.setPositiveButton(R.string.submit,
	this.getRenameClickListener(context, user, nameEdit))
	.setNegativeButton(R.string.cancel, null)
	.show();
	return true;

	private DialogInterface.OnClickListener getRenameClickListener(final Context context,
	final String user, final EditText nameEdit) {
	return new DialogInterface.OnClickListener() {
	@Override
	public void onClick(DialogInterface dialog, int whichButton) {
	String newName = nameEdit.getText().toString();
	if (newName != user) {
	if (mAccountDb.nameExists(newName)) {
	Toast.makeText(context, R.string.error_exists, Toast.LENGTH_LONG).show();
	} else {
	saveSecretAndRefreshUserList(newName,
	mAccountDb.getSecret(user), user, mAccountDb.getType(user),
	mAccountDb.getCounter(user));
	}
	}
	}
	};
	}