Comments (6)
Hi! I faced the same issue when migrating to 6.0.0. In my case the web view for allowing permissions dismissing immediately after present
Agree with @ivopintodasilva that setting scopes in signIn
would be way more convenient. For me, it looks strange when we need to show sign-in flow and then right after that ask for scopes in the case when we immediately need to do something with these scopes
from googlesignin-ios.
Hi! I was facing the same issue.
I've found workaround. I see that an issue is in
- (void)addCompletionCallback:(GIDAuthFlow *)authFlow
function.
self->_currentOptions.callback(self->_currentUser, handlerAuthFlow.error);
is waiting while my second block with addScopes
is working, so it calls self->_currentOptions = nil
, after saving new completion block.
My working solution is to call addScopes
in DispatchQueue.main.async
DispatchQueue.main.async { [weak self] in
guard let self = self else { return }
self.engine.addScopes(scopes, presenting: controller, callback: callback)
}
from googlesignin-ios.
The above behavior can be observed in this sample project: https://github.com/ivopintodasilva/GoogleSignIn-AddScopeTest
GoogleSignIn
is added to the project as a Swift Package and there are instructions in the README.md
file on how to run the project.
from googlesignin-ios.
Hi, I am facing similar issue. Due to this I am not able to update to latest version. Let me know when you get any update regarding this.
from googlesignin-ios.
Why are Google products always in beta and we are the guinea pigs? This addScopes method is idiotic. We used to be able to set the scope and sign in. Why is the user now having to be presented with another interface for approval? Why completely change your SDK and not provide deprecation notes to aid in the transition? This seems poorly executed. We need the ability to set the scopes required prior to sign-in as before and which is possible in the "internal options".
Also, it appears that even if I execute the addOptions method after the signIn method, that I am not actually getting those scopes. When attempting to access Google Drive, I get...
Error Domain=com.google.GTLRErrorObjectDomain Code=403 "Insufficient Permission: Request had insufficient authentication scopes." UserInfo={GTLRStructuredError=GTLRErrorObject 0x7fb2614681c0: {code:403 errors:[1] message:"Insufficient Permission: Request had insufficient authentication scopes."}, NSLocalizedDescription=Insufficient Permission: Request had insufficient authentication scopes.}
This is likely because it's not clear that the underlying user isn't changing and you have the return the new user from the secondary call. What a mess.
from googlesignin-ios.
@jkichline please refer to #23 for an explanation of the addScopes
API surface change you're referring to and feel free to leave any relevant feedback there. The implications of the change you mention are called out in the changelog but not elaborated on in the migration guide, which I'll address. You can refer to the Client-side Access guide for a detailed discussion.
from googlesignin-ios.
Related Issues (20)
- Update AppCheck baseURL to non-beta endpoint HOT 1
- Launch GSI 8.0.0 HOT 2
- Bump GSI version numbers to 7.2.0
- Update Changelog
- Merge fac-eap branch into main branch
- No library for this platform was found MacOS HOT 2
- Keep error domain `com.google.GIDSignIn` across the whole library.
- Clean up callback flow for sign-in and verify flow.
- GIDSignIn.sharedInstance.restorePreviousSignIn() sometimes fails to invoke completion handler
- The App crashes when launched via Widget. HOT 1
- Create example of VwG flow in existing "DaysUntilBirthday" sample app.
- Address VwG non-interactive flow (token refresh).
- Allow only requesting the oauth scopes that an app needs HOT 3
- Migrate current VwG refresh logic to `GIDGoogleUser`.
- Not Bulding for visionOs HOT 1
- Bump minimum iOS version to 12
- Increment AppCheckCore dependency to 11
- faulty App wants additional access to your Google Account
- faulty "App wants additional access to your Google Account" prompt HOT 5
- When implementing Google Sign-In on iOS, is it possible to indicate in the google account sign-in popup that only email address will be used?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googlesignin-ios.