Comments (3)
@petea what are your thoughts about this?
from googlesignin-ios.
GSI stores sign-in state in the default keychain group. If you have the Keychain Sharing capability enabled and one or more keychain access groups defined, the default keychain group will be the first item in this list of keychain access groups. Groups defined after this first group could be used for state sharing between apps without GSI state being present, if that's desired.
from googlesignin-ios.
@petea
In our apps the first keychain access group is the shared one, meaning GSI will store the state in a shared place that will be read and written by all our apps. That's undesired of course.
I can think of several ways to avoid such mistakes in the future:
- Keep the current behavior and explicitly mention this in the README.
- Use a different service for each app based on their bundle ID (Like being done in FB SDK). This will require migration which is not desired I assume.
- Allow to select the keychain storage name (Like being done in MSAL). Might also require migration
What do you think?
from googlesignin-ios.
Related Issues (20)
- iOS Widget - GIDSignIn Code=-4 (kGIDSignInErrorCodeHasNoAuthInKeychain) HOT 1
- Migrate off of archived firebase/OCMock SPM dependency HOT 1
- Swift package broken for v7.0.0 HOT 8
- swift-button-functional-test job failing due to changes in sign in flow HOT 1
- If user doesn't accept additional additional (not necessary scopes), return access_denied HOT 7
- Xcode 15.3 and App Store Connect Issue HOT 6
- Breaking issue: No visible @interface for 'OIDAuthorizationResponse' declares the selector 'tokenExchangeRequestWithAdditionalParameters:' HOT 14
- Calling GIDSignIn.sharedInstance.signIn, no callback is returned after successful authentication HOT 1
- `GIDSignIn.sharedInstance.signIn` does not return a callback sometimes HOT 5
- Request for Alamofire Dependency Update to Support Privacy Manifest in AlamofireObjectMapper HOT 7
- Implement GIDVerifyAccountDetail interface methods.
- PrivacyInfo manifest support HOT 1
- App rejected for Mac Catalyst due to opening external browser during Sign-In HOT 46
- Support for SDK Signature HOT 1
- How to downlaod GoogleSignIn with framework ? HOT 1
- Requesting the Google Sign In SDK in xcframework. HOT 1
- Facing compile time error with GoogleSignIn 7.1.0. HOT 1
- Upgrading to 7.1.0 from 7.0.0, now we can't `po` anything in lldb due to GTMSessionFetcher import issue. HOT 15
- Start the interactive add scopes flow.
- Uncomment and reenable using local GoogleSignIn.podspec in unit_tests.yml HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googlesignin-ios.