Giter VIP home page Giter VIP logo

Comments (2)

derekmauro avatar derekmauro commented on June 5, 2024 1

The problem here is that mockConnection is not related to std::shared_ptr<IConnection> const& by inheritance (because of the std::shared_ptr). EXPECT_CALL(*mockDatabase, connection()).WillRepeatedly(ReturnRef(mockConnection)); constructs a temporary std::shared_ptr<IConnection> which does not have the lifetime you expect.

Both Clang and MSVC warn here if you have the proper warnings enabled. For example:

googletest/googlemock/include/gmock/gmock-actions.h:1174:60: error: returning reference to local temporary object [-Werror,-Wreturn-stack-address]
 1174 |     Result Perform(const ArgumentTuple&) override { return ref_; }

Here is one way to write the test in your godbolt link:

TEST(Segv, ReturnRefMockFails)
{
    std::shared_ptr<StrictMock<DatabaseMock>> mockDatabase = std::make_shared<StrictMock<DatabaseMock>>();
    std::shared_ptr<StrictMock<ConnectionMock>> mockConnection = std::make_shared<StrictMock<ConnectionMock>>();
    auto iconn = std::static_pointer_cast<IConnection>(mockConnection);

    EXPECT_CALL(*mockDatabase, check()).WillRepeatedly(Return(true));
    EXPECT_CALL(*mockDatabase, connection()).WillRepeatedly(ReturnRef(iconn));
    EXPECT_CALL(*mockConnection, ok()).WillRepeatedly(Return(true));

    ASSERT_TRUE(mockDatabase->check());
    ASSERT_TRUE(mockDatabase->connection()->ok());
    ASSERT_EQ(mockDatabase->connection(), mockConnection);
}

from googletest.

neugepower avatar neugepower commented on June 5, 2024

Thanks @derekmauro! That is helpful and I will give it a try.

from googletest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.