Comments (7)
BOOL openedBrowser = [[NSWorkspace sharedWorkspace] openURLs:@[URL]
withAppBundleIdentifier:kSafariBundleID
options:0
additionalEventParamDescriptor:nil
launchIdentifiers:nil];
if (!openedBrowser) {
openedBrowser = [[NSWorkspace sharedWorkspace] openURL:URL];
}
from gtmappauth.
Just in case someone else runs into it. Just default it to open with safari instead
from gtmappauth.
@dsanghan Would you be willing to make a pull request?
from gtmappauth.
I feel we should plumb the desired bundle identifier out so that clients can use an explicit value, as in the example here. We should also expose some common browser bundle identifiers as constants for convenience. Default behavior can remain as-is, but clients who want to opt-in to safari-only or X-only can.
I believe this issue is otherwise more generally solved with the built-in callback server in AppAuth?
from gtmappauth.
Hi I added a sample project which included MacOs and swift support. I tested it on Chrome and it worked fine. The only thing I can think might be causing above is if the Url is not entered correctly into your Info.plist
#60 has the pull request - feel free to try it if it's still an issue.
from gtmappauth.
@grantkemp: I'd also opened an issue on chromium. Might have been fixed at their end. I'll recheck and close if needed. Thanks.
from gtmappauth.
As of Safari 11, Safari exhibits similar behavior (it closes the native prompt instead of ignoring user input like Chrome does).
The previous suggestion remains the best one (use the built-in callback server to avoid the dialogs altogether when using an IdP that supports PKCE, like Google).
Otherwise, this is a browser and IdP issue.
from gtmappauth.
Related Issues (20)
- Server Client ID for Mac auth HOT 2
- Reference AppAuth in Package.swift HOT 3
- Update usage of deprecated methods HOT 1
- iOS example not working HOT 1
- GTMAppAuth(GTMAppAuthFetcherAuthorization.o) build failure HOT 1
- Issues with OIDExternalUserAgent when requesting OIDAuthState HOT 2
- leaving old webview prompt
- Is GTMAppAuth considered OAuth OOB flow? HOT 3
- Use modern archiving and unarchiving methods in GTMAppAuthFetcherAuthorization.swift HOT 3
- Add support for GTMSessionFetcher 2.x HOT 4
- `pod lib lint` fails for watchOS on `macOS-12` runner HOT 1
- Ensure that `@objc(the_name)` for `AuthState` works with the new `KeychainStore` HOT 1
- g
- Re-enable watchOS platform in test specs
- Link generated documentation in README
- how to use for tvOS
- Need of required reason API policy HOT 2
- V2 to V4 pod migration: GTMAppAuthFetcherAuthorization(fromKeychainForName:) replacement HOT 2
- Privacy Manifest for GTMAppAuth HOT 2
- KeychainAttribute does not work as expected HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtmappauth.