Giter VIP home page Giter VIP logo

Comments (7)

dsanghan avatar dsanghan commented on August 15, 2024 1
    BOOL openedBrowser = [[NSWorkspace sharedWorkspace] openURLs:@[URL]
                                         withAppBundleIdentifier:kSafariBundleID
                                                         options:0
                                  additionalEventParamDescriptor:nil
                                               launchIdentifiers:nil];
    if (!openedBrowser) {
        openedBrowser = [[NSWorkspace sharedWorkspace] openURL:URL];
    }

from gtmappauth.

dsanghan avatar dsanghan commented on August 15, 2024

Just in case someone else runs into it. Just default it to open with safari instead

from gtmappauth.

StevenEWright avatar StevenEWright commented on August 15, 2024

@dsanghan Would you be willing to make a pull request?

from gtmappauth.

StevenEWright avatar StevenEWright commented on August 15, 2024

I feel we should plumb the desired bundle identifier out so that clients can use an explicit value, as in the example here. We should also expose some common browser bundle identifiers as constants for convenience. Default behavior can remain as-is, but clients who want to opt-in to safari-only or X-only can.

I believe this issue is otherwise more generally solved with the built-in callback server in AppAuth?

from gtmappauth.

grantkemp avatar grantkemp commented on August 15, 2024

Hi I added a sample project which included MacOs and swift support. I tested it on Chrome and it worked fine. The only thing I can think might be causing above is if the Url is not entered correctly into your Info.plist

#60 has the pull request - feel free to try it if it's still an issue.

from gtmappauth.

dsanghan avatar dsanghan commented on August 15, 2024

@grantkemp: I'd also opened an issue on chromium. Might have been fixed at their end. I'll recheck and close if needed. Thanks.

from gtmappauth.

StevenEWright avatar StevenEWright commented on August 15, 2024

As of Safari 11, Safari exhibits similar behavior (it closes the native prompt instead of ignoring user input like Chrome does).

The previous suggestion remains the best one (use the built-in callback server to avoid the dialogs altogether when using an IdP that supports PKCE, like Google).

Otherwise, this is a browser and IdP issue.

from gtmappauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.