Giter VIP home page Giter VIP logo

Comments (5)

MohitMandalia avatar MohitMandalia commented on May 18, 2024 1

@yschimke This might already be resolved please confirm I can see icon with correct alpha , please confirm

Screenshot 2022-07-10 at 7 00 30 PM

from horologist.

luizgrp avatar luizgrp commented on May 18, 2024 1

@MohitMandalia thanks for checking this, it looks like the issue happens with the placeholder icon. I've updated the issue title and description.

The issue also happens when an image is used instead of icon, which I will raise a separate issue for it:

disabled enabled
Screenshot_20220711_150839 Screenshot_20220711_151339

from horologist.

oas004 avatar oas004 commented on May 18, 2024 1

Hey, I was trying to look into this and I was wondering; is there a reason why you can not just apply a LocalContentAlpha.Current to the image if it is disabled? 😄 From the previews it seems correct, but I got thrown off by this

However, our implementation uses Coil's rememberAsyncImagePainter to display a placeholder, 
which receives a Painter type as placeholder, and might not work well with that alpha applied in Chip.

Does that mean that I would need to deprecate and alter the api to not get a painter as a placeholder? and then use something else than rememberAsyncImagePainter?

With the alpha applied to the images, it looks like this for the placeholder disabled preview

Screenshot 2022-08-29 at 16 49 12

from horologist.

yschimke avatar yschimke commented on May 18, 2024 1

@oas004 if you can see it fixed with this, please put up a PR. Thanks!

from horologist.

MohitMandalia avatar MohitMandalia commented on May 18, 2024

Okk cool.

from horologist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.