Comments (5)
@yschimke This might already be resolved please confirm I can see icon with correct alpha , please confirm
from horologist.
@MohitMandalia thanks for checking this, it looks like the issue happens with the placeholder icon. I've updated the issue title and description.
The issue also happens when an image is used instead of icon, which I will raise a separate issue for it:
disabled | enabled |
---|---|
from horologist.
Hey, I was trying to look into this and I was wondering; is there a reason why you can not just apply a LocalContentAlpha.Current to the image if it is disabled? 😄 From the previews it seems correct, but I got thrown off by this
However, our implementation uses Coil's rememberAsyncImagePainter to display a placeholder,
which receives a Painter type as placeholder, and might not work well with that alpha applied in Chip.
Does that mean that I would need to deprecate and alter the api to not get a painter as a placeholder? and then use something else than rememberAsyncImagePainter?
With the alpha applied to the images, it looks like this for the placeholder disabled preview
from horologist.
@oas004 if you can see it fixed with this, please put up a PR. Thanks!
from horologist.
Okk cool.
from horologist.
Related Issues (20)
- Dependabot doesn't create update PRs for version 0.5.20 HOT 2
- Node.isNearby is not reliable HOT 3
- Detect if audio offload support Opus HOT 4
- Chip doesn't set onClick label
- AmbientAware composable unnecessarily recreates the whole tree HOT 2
- Horologist media router usage HOT 1
- Compose-Layout transitive dep on compose-navigation HOT 4
- Improve tracking Tile installation HOT 2
- Invalid doc links
- Review pipeline initializations
- Use correct padding for all responsive SLC
- Use Responsive Dialog consistently
- [Feature request] scalingLazyColumnDefaults does not support userScrollEnabled parameter HOT 10
- Stop a release off a release branch from generating docs HOT 1
- rotaryWithScroll in Dialogs HOT 4
- Uamp isn't restarting playback after pause and resume HOT 2
- Using rotaryWithScroll and onRotaryInputAccumulatedWithFocus simultaneously HOT 5
- AGP 8.3.0 upgrade is blocked
- Improve Tile tracking initialization
- Some datalayer docs out of date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from horologist.