Comments (6)
Hi, sorry for the late reply
The problem is that the files we import from grafeas and the ones under /scannerlib/proto are .proto files that have to be compiled with protoc
into .pb.go files before we can link them against the rest of the source code.
The only way we can know about the files in advance is if we kept a precompiled .pb.go file for each .proto file around in the source, which we'd have to remember to update whenever we make changes to the .protos, so it'd add some complexity to the codebase.
from localtoast.
Hi @erikvarga - any update on this or consideration here?
from localtoast.
Though while I don't see a good way to fix the go mod tidy
issue, moving the grafeas deps into a git submodule would fix the non-networked env issue, so that could be a feature for us to consider.
from localtoast.
moving the grafeas deps into a git submodule would fix the non-networked env issue
Hm, except github doesn't allow releases that include submodules, which would make it not possible for people to just download the released .zip and build Localtoast from that :/
from localtoast.
Thanks for getting back to me on this!
download the released .zip and build Localtoast from that
That's exactly what I'd like to do (and since the environment this may be compiled on won't have a network, it'd be ideal to have all dependencies right there)
Have you considered dropping compiled binaries into releases? That could be a good first step
from localtoast.
Yeah, I think it should be possible for us to just add compiled binaries to our release
I added a compiled x86-64 binary and the config files to the latest release.
from localtoast.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from localtoast.