OpenSK firmware can not work well with nRF52840 dongle after 2e419fe77b37255778fe13166cdc891caee3b334 about opensk HOT 12 CLOSED

Thank you very much. I checked with latest source code, this issue and #81 have been solved.

from opensk.

Thank you for your report! The blinking might be a kernel panic? Is the blinking pattern different from before?
I'll assign to @ia0 because of the commit number for now.

from opensk.

The commit number is surprising, but there's indeed high chance that this is due to recent changes on the storage (in particular the fact that it moved outside and after the app).

@Geoffrey-Li When syncing at current HEAD (642ee69), one would need to do the following things for a clean install:

1. ./reset.sh &&./setup.sh before compiling OpenSK (but I guess you already did so otherwise it should not compile).
2. Some way to erase the pages after 0xC0000. There is a --clear-storage flag in the deploy.py script but the dongle is not supported yet. One solution I would see for now is to append 0xff padding at the end of the initial HEX file until at least 20 pages after address 0xC0000 (i.e. until 0xE4000 but 0x100000 would be even safer).

from opensk.

@kaczmarczyck , yes, using the source code after 2e419fe, in idle status, the LEDs blink quickly just like it receives CTAP2/U2F command.

@ia0, I download firmware though dfu. I'll try to clear all flash by using J-LINK before dfu.

from opensk.

@ia0 , I used J-LINK to clear all flash, 1024K+separate 4K, and then downloaded Open bootloader, downloaded OpenSK through DFU. Same behavior. LEDs blinks and CTAP2/U2F can not work. It seems CTAPHID_INIT does not return.

from opensk.

Then this looks unexpected. I can't reproduce on a dev-kit. I'll try to see if I can reproduce on a dongle tomorrow.

from opensk.

Same issue for a genuine Nordic usb dongle : leds 1 and blue are blinking simultaneously around 200ms and no success on testing at webauthn.io.
I've been trying with half success commit 2e419fe and branch HMAC-secret-extension :

• if dongle not unplugged once, it works - tested on webauthn.io.
• if dongle unplugged once, replug puts it in DFU mode - red slowly blinking.

Therefore, there are 2 issues for me :

• 2 leds blinks and not working at all - this issue
• And : erroneous flash - it looks like it's been used --no-persistent-storage option at deploy.sh

from opensk.

Odd issue : when passing "--no-persistent-storage", the key works well (commit 2e419fe) without default to DFU behavior anymore !

from opensk.

One more action : master branch and --no-persistent-storage seems to solve the issue...
git checkout master; ./reset.sh; ./setup.sh
and :
./deploy.py --board=nrf52840_dongle_dfu --opensk --programmer=nordicdfu --no-persistent-storage

The dongle work well at webauthn.io, no blinking leds and furthermore, even when unplugged before !

from opensk.

Thanks for the investigation. The fact that --no-persistent-storage fixes the issue is a good sign that this has to do with the fact that the persistent storage moved out of the application (the storage probably fails to initialize for some reason). What is still unclear to me is why this only affects the dongle (or the DFU way of flashing the dongle). I'll look into this tomorrow.

from opensk.

I could reproduce the issue on a dongle. But it is still unclear what is the cause of the issue.

I tried to reproduce on a dev-kit using a DFU and flashing a merged hex file with a modified dev-kit board to support DFU. This experiment did not show any issue. So the problem may be:

• When using the DFU to flash the hex file (since flashing the hex file directly works on dev-kit).
• Something specific to the dongle.

from opensk.

The problem was indeed specific to the dongle. The board of the dongle did not define the storage location. #119 fixes the issue.

from opensk.