Compiling with Bazel is broken on Windows about perfetto HOT 10 CLOSED

Thanks for filing! https://r.android.com/3081311 should fix issue 3. If you could send fixes for 1 and 2, that would be very much appreciated!

from perfetto.

Thank you for such a quick fix!

1. https://android-review.git.corp.google.com/c/platform/external/perfetto/+/3079270
   • I need some guidance on how to modify/add BUILD files, since I'm unfamiliar with how they are supposed to be generated.
2. https://android-review.git.corp.google.com/c/platform/external/perfetto/+/3083587

from perfetto.

I need some guidance on how to modify/add BUILD files, since I'm unfamiliar with how they are supposed to be generated.

I've commented on the change.

from perfetto.

At change 8ff5262 everything is now building on Windows :)

from perfetto.

Reopening, since there was a revert (0a0f29f). Is it possible to rename ui/build to something else, to avoid Bazel on Windows from thinking it is a Bazel package (BUILD)?

from perfetto.

Can you reach out to @stevegolton internally to discuss?

from perfetto.

Can we just add /ui in $root/.bazelignore (feel free to send a CL for it) ?

Can I ask what are you trying to do? Specifically why do you need bazel on windows and can't use GN instead?

My only fear is that we keep piling up combinations of build system and platforms. We can't commit to maintain anything else other than GN, which is our primary build sytem (and Android.bp for android). The rest is all best effort, which means somtimes it will break without us realizing and you'll have to figure out.

from perfetto.

Adding a .bazelignore would be a great solution, I forget that exists.

Our project (Android Studio) builds with Bazel and its build graph depends on perfetto dependencies, so we cannot use GN without significant changes on our end.

from perfetto.

Ah gotcha. Yeah send a patch with .bazelignore, feels like it should make the problem go away easily

from perfetto.

This was done in aosp/3092494

from perfetto.