Allow only valid email address with @ in email subscription about personfinder HOT 13 CLOSED

I would like to work on this bug. I started off with cloning pf, but then stalled on where to start. While I'm comfortable with normal python, I'm new to django & google app engine. Can you please provide me some pointers to how to start? Is there any bootstrap & configure script to start / set-up?

from personfinder.

Hello @kspviswa ,

It's great to hear that you are interested in development of Person Finder. Here is a GettingStarted doc:
https://github.com/google/personfinder/wiki/GettingStarted

Let me know if anything is unclear.

from personfinder.

@kspviswa I would also like to contribute, The situations same on this end comfortable with python, I was hoping maybe we can work togather.

from personfinder.

@Aloknayan Welcome to pf. To get started please look @ gettingstarted link as suggessted by @gimite . BTW I've started working on this issue. I would suggest you to work on some other issue, to prevent our efforts being duplicated.

@gimite Is there any way, to assign the issues to ourselves ? Something liking picking ?

from personfinder.

@kspviswa You can just write your interest here as you have already done.

from personfinder.

Thank you very much kspviswa@ for the great contribution. The change is going to be merged to the default branch and pushed at the next server deployment (hopefully very soon).

from personfinder.

@skywhale Thanks for your helpful reviews and motivation. @gimite Thanks for pointing to quick start link, which enabled be to start quickly .

BTW could you help me in selecting next bug? I'm eager to contribute more :)

from personfinder.

@skywhale @gimite Can this bug be closed?

from personfinder.

Actually the original bug says that I once found a record with an invalid mail address in the data store in the server. Since you pointed out that there was already a validation in the server side, it shouldn't have happened. I will close this bug after verifying that there is no other data flow to put the address without validation.

from personfinder.

It's possible to enter an invalid email address for the found person (email_of_found_person). I couldn't find any code that tries to send emails to that address, so I'm not sure it could have caused a cron job to fail, but it's been 2.5 years, so maybe there used to be code that needed it to be valid.

from personfinder.

It seems like a deliberate decision was made to only validate email addresses when they're used for subscriptions (the email validation code is within the subscription class). I'll check with Pete or Nobu to see if there's any product reason not to validate non-subscription emails.

from personfinder.

I'm not sure it could have caused a cron job to fail, but it's been 2.5 years

As far as I know, we only used subscription email to send emails.

from personfinder.

I think I figured this out: when records are deleted, messages are sent to associated emails (record and note author emails); this happens at line 74 of app/delete.py. Those emails are validated client-side, but not server-side.

from personfinder.