Comments (15)
Did some code cleanup/fixes and merged into main
. Unsure of total stability at this point, but stable enough to pass basic testing.
Now it looks like a proper project!
from purr.
Created a PR Homebrew/homebrew-core#156118
from purr.
Seeing from my work laptop:
> brew install purr
...
==> Summary
🍺 /opt/homebrew/Cellar/purr/2.0.4: 7 files, 86.8KB
> purr
Waiting on a device to connect...
Looks finished to me.
Thanks for the work on this @bartekpacia!
from purr.
Yeah! Huge thanks to you as well! I'll try packaging purr for AUR next (hopefully it'll reach extra
after some time!)
from purr.
Hey Bartek,
Thanks for the kind words. I hope you keep finding it useful :)
I'll endeavour to get it on Homebrew. I can see that fzf
has been updated to 0.40.0 on Hoembrew, which is the version I need, so I can likely collapse the script folder into just the purr
script.
This is somewhat impeded by us not using Homebrew internally, so no promises on timing, I need to figure out how to sideload it.
Thanks!
from purr.
Hi @alpiccioni – I keep using purr
and am loving it.
Could I try to contribute this if you don't have time?
from purr.
Hey Bartek, I'd really appreciate it! I've been slacking a bit on the packaging issues :P
from purr.
Hi @alpiccioni – I keep using
purr
and am loving it.Could I try to contribute this if you don't have time?
Just as a head's up, I am splitting purr up into source files that can be compiled into a single executable through a "make" command. I should push the final build by the end of the week. This might (should?) make it easier to package things up!
from purr.
That sounds great! I haven't yet started doing anything because of lack of time, but I hope to do it soon
from purr.
That sounds great! I haven't yet started doing anything because of lack of time, but I hope to do it soon
No problem; do what you can when you can!
from purr.
Hi @alpiccioni, just checking in to ask if you have any plans to merge code-restructure
to master
? Then I could start homebrewing it:)
Also, I'd like to ask what's the motivation for bundling fzf
in the repo? If purr
will be onboarded to package managers (Homebrew, apt, pacman?), then I think that managing dependency on fzf
should be that package manager's responsibility.
from purr.
Hey! Yup, slipped my mind. Let me get to it tomorrow and make sure it's running smooth and then merge it.
The code restructure should drop the fzf
bundling. You are correct that it should be handled by the package manager! However, the core problem here is that part of the functionality relies on version 0.40.0
, and the Google-internal Linux version didn't support that version until recently.
However, now that it's been updated, the bundled dependency should be removable.
from purr.
Awesome!
For the test block, if that becomes a problem, I can look into creating a bypass. I think testing purr
is going to be very difficult because it exists on top of fzf
, which is pretty opaque, so testing the UI would be difficult.
What I could do is create a test suite that initializes purr
with a mocked ADB client, feeds it some data, and checks if the backing files have initialized correctly. That would at least check if it purr
can boot correctly.
Thanks for doing this!
from purr.
That's nice of you, thanks! Though I'm not sure if the test
block is that hard of a requirement for a formula to be in homebrew-core
. Maybe you can chime in in that PR (basically copy-paste the above comment)? Maybe if we explain that testing purr
is not that simple, there won't be problems with getting that merged.
from purr.
Done. Thanks!
from purr.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from purr.