Shouldn't this public function check for null? about s2geometry HOT 4 CLOSED

I don't think so. Could you explain why you think it should check for null?

The (undocumented, but hopefully apparent) precondition is 0 <= i && i < num_vertices(). Do you have an example test case that would be affected by your proposed change?

from s2geometry.

I only asked cause it looks like a public facing API, I'm used to checking those for erroneous/malicious user input.

from s2geometry.

This is a pretty common pattern in C++, in general you don't want to pay the cost for bounds checking. We have the new iteration API that prevents this is in the common case anyways. If we did bounds check then we have the question of what we would return when it fails. We don't use exceptions so we'd have to return a std::optional or absl::StatusOr probably, which would be a breaking change.

from s2geometry.

closing then, ty

from s2geometry.