Use context for timeouts about safebrowsing HOT 2 CLOSED

I think passing a context to LookupURLs (or something like LookupURLsWithContext) is a great idea.

So right now, a timeout is set on the http client. That doesn't stop us from adding a context to the request, but we could consider moving all timeout related operations to contexts instead of the http client. I'm not sure which is cleaner.

from safebrowsing.

The simplest backwards-compatible way would be to keep the default timeout config option, and combine it with any provided context. So for instance, LookupURLs would call LookupURLsContext(context.Background, ...), and LookupURLsContext(ctx, ... would call ctx = context.WithTimeout(ctx, defaultTimeout). That way if the passed context has a shorter timeout, it would be observed, but if it has a longer timeout, it would be shortened to match the default timeout.

from safebrowsing.