Giter VIP home page Giter VIP logo

Comments (3)

tomayac avatar tomayac commented on May 17, 2024

As you write, this works fine in stable (70), but fails in 71. Since it's a perfectly valid parameter, I suggest you open a bug with Firefox. It was required for whatever reason when I developed this, but as it just sets the value to the default of false, this shouldn't fail. I'm closing here, please feel free to comment with the Firefox bug ID for people interested to follow this.

from service-worker-detector.

tomayac avatar tomayac commented on May 17, 2024

FWIW, a work-in-progress fix addresses this with two ugly nested try … catch blocks (it's not been deployed to the add-on store yet, but works fine locally on both Firefox 70 and 71).

service-worker-detector/contentscript.js

Lines 152 to 163 in 463d2b3

try {
return browser.runtime.sendMessage(null, result);
} catch (e) {
try {
// ⚠️ TODO: Why does Firefox require ```option.toProxyScript```?
return browser.runtime.sendMessage(null, result, {
toProxyScript: false,
});
} catch (e) {
return browser.runtime.sendMessage(null, result);
}
}

from service-worker-detector.

gwarser avatar gwarser commented on May 17, 2024

This proxy API was removed: https://bugzilla.mozilla.org/show_bug.cgi?id=1443259

Why you are calling sendMessage with null?

from service-worker-detector.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.