Giter VIP home page Giter VIP logo

Comments (5)

aaemnnosttv avatar aaemnnosttv commented on May 24, 2024

AC ✅

from site-kit-wp.

eugene-manuilov avatar eugene-manuilov commented on May 24, 2024

Thanks, @zutigrm, but this is not what we need to do. We can do it simpler if we just call the receiveIsCustomDimensionGatheringData( customDimension, true ) action in the createCustomDimensions action after the custom dimension has been created. I think this should do the trick and those widgets won't send report requests.

from site-kit-wp.

zutigrm avatar zutigrm commented on May 24, 2024

@eugene-manuilov Thanks for the valuable feedback! That's much more straightforward indeed. IB is updated

from site-kit-wp.

eugene-manuilov avatar eugene-manuilov commented on May 24, 2024

Thanks, @zutigrm. IB ✔️

from site-kit-wp.

wpdarren avatar wpdarren commented on May 24, 2024

QA Update: ✅

Verified:

  • While POST requests to create-custom-dimension & sync-custom-dimensions are made, no report requests are made containing the newly created custom dimensions.
  • An error as described with the steps to reproduce in the issue description cannot be reproduced anymore.
  • Upon reloading the page, the report requests are made containing the newly created custom dimensions and they appear without errors as described in the issue description.
Screenshots

image
image
image
image

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.