Comments (5)
AC ✅
from site-kit-wp.
Thanks, @zutigrm, but this is not what we need to do. We can do it simpler if we just call the receiveIsCustomDimensionGatheringData( customDimension, true )
action in the createCustomDimensions
action after the custom dimension has been created. I think this should do the trick and those widgets won't send report requests.
from site-kit-wp.
@eugene-manuilov Thanks for the valuable feedback! That's much more straightforward indeed. IB is updated
from site-kit-wp.
Thanks, @zutigrm. IB ✔️
from site-kit-wp.
QA Update: ✅
Verified:
- While POST requests to
create-custom-dimension
&sync-custom-dimensions
are made, no report requests are made containing the newly created custom dimensions. - An error as described with the steps to reproduce in the issue description cannot be reproduced anymore.
- Upon reloading the page, the report requests are made containing the newly created custom dimensions and they appear without errors as described in the issue description.
from site-kit-wp.
Related Issues (20)
- Update PAX conversion tracking service for compatibility with v1 HOT 5
- Update the Ads Conversion ID migration notice to dismiss based on first view
- Dashboard Sharing errors when a user tries to change the active key metric tiles
- Avoid layout shift when showing the Setup CTA Banner. HOT 4
- Only show one of the Consent Mode and Audience Segmentation Setup CTA Banners at a time.
- Visual difference in the view only vs standard SK dashboard with number of KMW tiles shown HOT 2
- [Post July 31st, 2024] Remove the conditionality for including Switzerland in the list of regions for the EU user consent policy.
- Add Google Ads to the Supported Google tools section on the Site Kit plugin page
- Add `whenInViewContext` higher-order component (HOC) to allow simplification of code that should only run inside some view contexts
- Upgrade PHPCS standards
- Extract "Subtle Notification" styling/logic to a shared `SubtleNotification` component
- Refactor the Audience Tiles to use new pivot report infrastructure HOT 2
- Update component styles to reference tokens
- Refactor settings Save button loading state
- Ads conversion ID not output when connected via PAX HOT 2
- Ads PAX Setup Flow Not Proceeding Past Billing Screen Due to `termsAndConditionsService.notify` Function Body Being Empty HOT 2
- Update ICE permissions to require `MANAGE_OPTIONS` HOT 1
- Release 1.128.0
- URLs with arabic characters always showing zero data, despite data existing from analytics.google.com HOT 1
- Address copy/formatting inconsistencies in "subtle" notifications?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.