Giter VIP home page Giter VIP logo

Comments (5)

adamdunnage avatar adamdunnage commented on May 28, 2024

Hi @Philipp91 thanks for opening this issue. We do not provide support via GitHub so could I ask you to please open a new support topic with us and we will be happy to look into this further with you.

Thanks!

from site-kit-wp.

Philipp91 avatar Philipp91 commented on May 28, 2024

I don't need support (I'll go figure out that ModSecurity issue myself). I filed a bug about how the plugin behaves wrt. error reporting towards the user (with users in mind who couldn't debug this with DevTools like I did myself). I'm basically asking for those pre-existing bugs to be reopened, as they weren't really fixed, as my experience above proves.

from site-kit-wp.

adamdunnage avatar adamdunnage commented on May 28, 2024

@Philipp91 Understood, I will reopen this for review by the team. Thanks for flagging.

from site-kit-wp.

Philipp91 avatar Philipp91 commented on May 28, 2024

Indeed I got it to work by temporarily disabling that ModSecurity rule. And in fact, a simple link for doing so was already included in the error message.

Btw the same kind of error also happens in the background now that I've got everything set up, when I open the Analytics settings in the sitekit plugin again, change a setting and click on "Apply changes". Except that here, no error message is shown, it simply doesn't go on to save and doesn't close the form. So here, that issue is even harder to debug.

I strongly suggest that, for your (presumably thousands of) users' sake, you parse apart that error message, output a more useful error to the user and include the link for ModSecurity deactivation (the https://{mydomain}/ /modsec/?domain=[{mydomain}](http://{mydomain}/)&ip={myip}&path=/home/ch309093/web/[{mydomain}/public_html](http://{mydomain}/public_html) part of the error I sent above) directly into the output. So tell your users something like: "Your webserver rejected the plugin's attempt to access/update its settings. This is likely due to ModSecurity blocking this access. You can try disabling ModSecurity entirely for a short amount of time, or visit the following link to disable specifically the one rule that blocked your access: https://{mydomain}/ /modsec/?domain=[{mydomain}](http://{mydomain}/)&ip={myip}&path=/home/ch309093/web/[{mydomain}/public_html](http://{mydomain}/public_html). Note that sometimes after updating ModSecurity you need to wait a couple of minutes before the change takes effect. Then retry this action."

from site-kit-wp.

bethanylang avatar bethanylang commented on May 28, 2024

Thanks for these details, @Philipp91! We'll dig into this further and consider a future enhancement for Site Kit. Feel free to continue to follow this issue for updates.

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.