Release 1.114.0 about site-kit-wp HOT 12 CLOSED

QA ❌

✅ Performed a general smoke test of the plugin.
❌ - Smoke tested/verified the changes I’ve been involved with.
✅ - Performed some ad-hoc testing.

I've spotted a regression, although it's a very minor one. The focus state for the Settings > Key Metrics > Edit button is now clipped.

This is a result of this overflow: hidden that was added via #7747.

We can easily fix this by adding a right-hand margin to the Edit button, thus moving it to the left by a few pixels. Alternatively, to avoid moving the button we could remove the overflow: hidden, although we'd then need to revisit the loading state that it was introduced for and this would get a bit more complicated.

It's also such a marginal issue we could avoid holding up the release and create a new issue to address it in the next one.

What do you think, @aaemnnosttv?

from site-kit-wp.

Thanks @wpdarren. Actually, further on the above I've noticed we have this issue in the current sprint which will result in the styling for the Edit button changing. I suspect this should resolve the cut-off focus issue by default, and we can certainly address it there. So I think we can avoid holding up the release and don't need to create a new issue either.

from site-kit-wp.

It's also such a marginal issue we could avoid holding up the release and create a new issue to address it in the next one.

What do you think, @aaemnnosttv?

@techanvil the focus clip is fine to address in a follow-up; no need to block the release 👍

from site-kit-wp.

QA Update: ✅

• Went through our release testing checklist:
  • Tested Site Kit on a site with gathering status.
  • Tested Site Kit on a site with zero data state.
  • Tested Site Kit on a site with live data.
• Tested view only dashboard for all the statuses above, gathering, zero and live data.
• Tested AdBlocking Recovery.
• Tested Enhanced Measurement.
• Tested Tooltip Tours.

Note: did not complete any testing on UIV2 or (N)KMW since we'll be final testing before launch.

from site-kit-wp.

QA Update ✅

• Ran QA check list.
• Tested Site kit set up.
• Tested Analytics set up with Enhanced measurement functionality.
• Tested Dashboard sharing functionality.
• Tested zero and gathering state.
• Tested Ad blocking recovery set up.

from site-kit-wp.

QA ✅

• Tested set up and upgrade of site
• Tested set up with and without Analytics
• Tested Dashboard Sharing

All looked good to me 👍🏻

from site-kit-wp.

Release Tested ✅

• Release tested 1.114.0 thoroughly.
• Set everything up from scratch on a live (InstaWP) site.
• Didn't spot any unexpected console errors.
• Verified UI in different device breakpoints.
• Verified changes I've been involved with.
• Used the release testing checklist to ensure everything was checked.
• Tested Dashboard Sharing.
• Tested Enhanced Measurement.
• Tested Key Metrics Widget.

from site-kit-wp.

Release QA ✅

• Tested the Key Metrics widget in multiple scenarios (mini-bug bash style). Didn't find any new issues.
• Smoke tested rest of the plugin using the usual check list.

from site-kit-wp.

QA Verified ✅

• Smoke tested.
• Verified the changes I’ve been involved with.
• Performed some ad-hoc testing.

LGTM 👍

from site-kit-wp.

Release QA ✔️

• Went through the regular release checklist, setting up everything on a fresh site, and updating plugin on an existing site with data.
• Did some extensive testing on User Input and Key Metrics.
• Went through AdSense setup and Ad Blocking Recovery setup flows.

LGTM 👍

from site-kit-wp.

Release QA ✅

• Smoke tested against the checklist
• Verified changes I've been involved with
• Went through the release testing changelog
• Checked on different device sizes
• Tested key metrics and enhanced measurement

from site-kit-wp.

@techanvil good spot. I have just recreated this and on mobile it looks a little bit worse because the focus state appears over the question. Like you said minor. It doesn't feel like we should hold up the release for but will leave that call with Evan.

from site-kit-wp.