User input survey answer attribution changes without changing answer about site-kit-wp HOT 6 OPEN

@10upsimon Looks good, but can you add an estimate and fill out the "tests" section of the IB? This could use a unit test I think 🙂

from site-kit-wp.

IB ✅

Just bumping down to 11 again given the test removal 🙂

from site-kit-wp.

@10upsimon Looks good, but can you add an estimate and fill out the "tests" section of the IB? This could use a unit test I think 🙂

Thanks @tofumatt , I have implemented test suggestion in the form of JS tests, and estimated at 15. I had it at 11, but I feel that due to tests being introduced in an area that does not appear to have tests yet, this needed a bump.

Assigning back to you.

from site-kit-wp.

Tests are being implemented separately as part of #7922. Given that we do not have PHPUnit tests that cover this area of the codebase, it was discussed in Slack that it would cause an unnecessary bloat in effort to introduce tests as part of this issue.

from site-kit-wp.

Note for Execution: Per this discussion, we should have a bit different approach for the provided PoC in IB - $answers['purpose']['values'] and $existing_answers['purpose']['values']should be checked in order to attribute correct user when purpose answer changes

cc: @10upsimon @tofumatt

from site-kit-wp.

QA Update ✅

• Tested on dev environment.
• Able to reproduce issue on latest environment.
• Verified that on dev environment issue is resolve.
• If Admin B don't change Purpose answer then for Admin B or Admin C under settings. Admin A is appear as person who answered the question.
• If Admin B change purpose answer then for Admin A or Admin C under settings Admin B appear as person who answered the question.

from site-kit-wp.