Setup completion tracking no longer working as expected about site-kit-wp HOT 8 CLOSED

Thanks @wpdarren , the points 2 & 3 were just an added bonus not something that was tracked before, or part of the requirements, so I will remove tracking from view only, as it will consume to much effort, will focus only on first point around GCP setup

from site-kit-wp.

IB ✅

from site-kit-wp.

QA Update: ❌

@zutigrm I have three observations:

1. The complete_site_setup and complete_user_setup GA events are not getting triggered when setting up Site Kit with the GCP flow. I tried this on two different sites.
2. I am unable to see the complete_user_setup GA event being triggered when connecting/signing in from view only dashboard menu Sign in with Google See screencast.
3. On the splash screen where it says, Site Kit has already been configured by another admin of this site. and I set up Site Kit with another Google account, and 2nd admin user, the GA events are not getting triggered here. This might be expected but would like to check.

from site-kit-wp.

@wpdarren I was just looking at this with @zutigrm and confirmed the only issue to fix here is around the tracking when not using the proxy. We verified that the second admin is tracked correctly as well as the sign in from the view-only user menu. It seems the reason you didn't see it is due to not opting in to the tracking, as can be seen in your screencast so that would be WAI ;)

@zutigrm is working on finishing up his follow-up PR for the GCP side and this should be back in QA soon.

from site-kit-wp.

Back to you @wpdarren 👍

from site-kit-wp.

@aaemnnosttv oops, that was stupid of me, noted.

QA Update: ⚠️

@zutigrm I noticed on the GCP side that the complete_user_setup is getting triggered but I can't see complete_site_setup GA Event. I have tried this a few times. I made sure oAuth was cleared, and also local and session storage. According to the AC this should be tracked but not seeing this. Could you take a look?

from site-kit-wp.

Thanks @wpdarren , I left my comment in slack thread, with some info for @aaemnnosttv - as I will need your confirmation on the direction, TLDR - since connected status is always true we will need to always track site setup event, regardless if Site Kit is setup first time or by secondary admins, since we can't distinguish the connections status in GCP, like we can with Proxy component

from site-kit-wp.

QA Update: ✅

Verified:

• Events listed in AC are being tracked after successful setup, regardless of setting it up with or without GA4.
• When I cancel the flow and return back with an error message, events are not tracked.

Note: we decided not to concern ourselves with GCP GA events, and I can confirm for the events are getting tracked as per the AC after successful setup, regardless of setting it up with GA4 or without.

from site-kit-wp.