Comments (8)
Thanks @wpdarren , the points 2 & 3 were just an added bonus not something that was tracked before, or part of the requirements, so I will remove tracking from view only, as it will consume to much effort, will focus only on first point around GCP setup
from site-kit-wp.
IB ✅
from site-kit-wp.
QA Update: ❌
@zutigrm I have three observations:
- The
complete_site_setup
andcomplete_user_setup
GA events are not getting triggered when setting up Site Kit with the GCP flow. I tried this on two different sites. - I am unable to see the
complete_user_setup
GA event being triggered when connecting/signing in from view only dashboard menuSign in with Google
See screencast. - On the splash screen where it says,
Site Kit has already been configured by another admin of this site.
and I set up Site Kit with another Google account, and 2nd admin user, the GA events are not getting triggered here. This might be expected but would like to check.
ga-events.mp4
from site-kit-wp.
@wpdarren I was just looking at this with @zutigrm and confirmed the only issue to fix here is around the tracking when not using the proxy. We verified that the second admin is tracked correctly as well as the sign in from the view-only user menu. It seems the reason you didn't see it is due to not opting in to the tracking, as can be seen in your screencast so that would be WAI ;)
@zutigrm is working on finishing up his follow-up PR for the GCP side and this should be back in QA soon.
from site-kit-wp.
Back to you @wpdarren 👍
from site-kit-wp.
@aaemnnosttv oops, that was stupid of me, noted.
QA Update: ⚠️
@zutigrm I noticed on the GCP side that the complete_user_setup
is getting triggered but I can't see complete_site_setup
GA Event. I have tried this a few times. I made sure oAuth was cleared, and also local and session storage. According to the AC this should be tracked but not seeing this. Could you take a look?
ga.mp4
from site-kit-wp.
Thanks @wpdarren , I left my comment in slack thread, with some info for @aaemnnosttv - as I will need your confirmation on the direction, TLDR - since connected status is always true
we will need to always track site setup event, regardless if Site Kit is setup first time or by secondary admins, since we can't distinguish the connections status in GCP, like we can with Proxy component
from site-kit-wp.
QA Update: ✅
Verified:
- Events listed in AC are being tracked after successful setup, regardless of setting it up with or without GA4.
- When I cancel the flow and return back with an error message, events are not tracked.
Note: we decided not to concern ourselves with GCP GA events, and I can confirm for the events are getting tracked as per the AC after successful setup, regardless of setting it up with GA4 or without.
from site-kit-wp.
Related Issues (20)
- Release 1.134.0 HOT 4
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.`
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
- Fix glitches in the Audience Segmentation Setup CTA Banner
- "Looks like your site is not allowed access to Google account data" error, despite no changes made
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.