Giter VIP home page Giter VIP logo

Comments (3)

mithro avatar mithro commented on July 30, 2024

I'm very supportive of adding flake8 and think it should be checked on probably Travis CI. At the moment Travis CI just checks you have updated README.rst from README.src.rst -- https://github.com/google/skywater-pdk/blob/master/.travis.yml#L27-L30

Generally we have used yapf rather than black for auto-formatting and would probably want to keep this consistent with the SymbiFlow projects - https://github.com/SymbiFlow

I'm open to exploring GitHub actions but have not used it in this capacity before.

from skywater-pdk.

cclauss avatar cclauss commented on July 30, 2024

I could add to either Travis CI or GitHub Actions. Please let me know which way you want to go.

from skywater-pdk.

mithro avatar mithro commented on July 30, 2024

@cclauss We should probably have a make check or similar type option in the Makefile first and then enable that checking on Travis CI / GitHub Actions?

Do any of the new GitHub actions do fancy things like publishing the output into the pull request as comments? That would be super cool to see.....

FYI -- For a consistent cross-platform Python 3 environment we are using Conda and will eventually use the EDDA packages (https://bit.ly/edda-conda-eda-spec).

from skywater-pdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.