Comments (6)
My personal opinion:
It is not confusing to put separate language files in separate roots. In fact, it's the opposite. It helps keep things organized and makes it easier to find the code. google3 and most multi-language github projects I've seen do this.
That said, I don't know enough about bazel to have a strong, informed opinion here. But I do think most Java developers will find the existing layout confusing.
from startup-os.
Do you mean that,
com.google.startupos.tools.reviewer.aa.AaTool
is in folder tools/reviewer/aa
instead of java/com/google/startupos/tools/reviewer/aa
and tests in javatests/com/google/startupos/tools/reviewer/aa
?
from startup-os.
Yes, that's what I meant.
from startup-os.
Right, so we've actually had some discussions on that, here:
#30
The idea is that Bazel is a multi-language built tool, so if a repo has multiple projects, and say some project has java, scala, c++, python and proto (quite conceivable), it's confusing to have each in a separate root folder, i.e:
java/com/google/startupos/tools/reviewer/aa
javatests/com/google/startupos/tools/reviewer/aa
and then similarly,
<language>/com/google/startupos/tools/reviewer/aa
<language>tests/com/google/startupos/tools/reviewer/aa
for every language.
So the idea is that we organize folders based on projects, and keep project-related files together.
from startup-os.
How do we move forward with this issue?
from startup-os.
I'm not sure what you mean by a root here. google3 certainly does separate java, C++, etc. into separate directory structures and google3/java follows java conventions on package organization. In this case google/startup-os is the equivalent of google3.
from startup-os.
Related Issues (20)
- `base_folder/head` contains two folders with `startup-os` repos
- The Firebase token expiration
- Create a simple HTML + js page to replace web_login HOT 1
- Use the usernames defined in the repo
- Fallback server bug HOT 1
- Delete old projects with vulnerabilities
- Update Reviewer to Angular 7 HOT 1
- Reviewer Lite
- Option to mark a file as reviewed on diff page
- File expand bug
- Upload queue [BUG] HOT 1
- Blocks should have the same amount of lines [BUG]
- Shared protoc
- Fix reviewer deprecations
- Create a derivative user collection in `hasadna` to that in `startup-os`
- Is there any way to use MessageDifferencer from this repo by adding a maven dependency in my code? HOT 8
- MessageDifferencer ignoreFields doesn't work for RepeatedFields. HOT 4
- Has this been abandoned? HOT 10
- Error: "Project startup-os has been deleted" on build HOT 2
- gRPC microservices example can not run: GitRepoFactory.java is missing in repository. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from startup-os.