Comments (9)
Deleting chrome.exe and rebuilding did not resolve the problem. Deleting chrome.exe and chrome.exe.pdb and rebuilding also didn't help. For some reason I have only seen this on gn official builds of chrome.exe.
Here's the output from checking the GUID/age of chrome.exe/chrome.exe.pdb, and then sizeviewer.py failing:
C:\src\Temp\foo>pdbinfo chrome.exe.pdb
Timestamp GUID age
578452F2, {801EF37A-84B3-4DD5-B7A1-243401FEC766}, 4
C:\src\Temp\foo>dumpbin /headers chrome.exe | find /i "rsds"
57855971 cv 5F 000F81DC F6BDC Format: RSDS, {801EF37A-84B3-4DD5-B7A1-243401FEC766}, 4, C:\src\chromium4\src\out\gn_release_official\initialexe\chrome.exe.pdb
C:\src\Temp\foo>python c:\src\chromium4\src\tools\win\sizeviewer\sizeviewer.py chrome.exe
Tallying chrome.exe...
[0712/142001:INFO:application_impl.h(46)] Syzygy CodeTally Version 0.8.19.0 (da2c31c).
[0712/142001:INFO:application_impl.h(48)] Copyright (c) Google Inc. All rights reserved.
[0712/142001:ERROR:pdb_info.cc(93)] Unable to process PE file: chrome.exe
[0712/142001:ERROR:code_tally.cc(108)] PDB file 'chrome.exe.pdb' does not match image file 'chrome.exe'.
gn builds settings are:
is_component_build = false
is_debug = false
is_official_build = true
Build position is 1e4191f489c9aff5e298a895aed4d663864599a7
from syzygy.
Note that this is a 64-bit build. Maybe that is the problem?
from syzygy.
The Syzygy tools really haven't been tested against 64 bit builds. There's no reason why the code tally wouldn't work with 64 bit builds, as it only really walks the symbols, except this one place where it leans on the binary to get at the symbols.
from syzygy.
Updating the title to list the actual root cause. Given that Chrome now defaults to 64-bit on Windows it may be important to update this. Maybe?
from syzygy.
I'll take a look-see, though we don't envision porting Syzygy at large to 64 bit.
from syzygy.
At the very least it would be nice if syzygy's various tools gave better error messages when asked to process 64-bit binaries. That would have made investigating this breakage easier: crbug.com/628055
from syzygy.
Syzygy is pretty much in maintenance mode now, there really isn't a team
backing it any more. CLs are welcome, though.
On Thu, Jul 14, 2016 at 1:20 PM Bruce Dawson [email protected]
wrote:
At the very least it would be nice if syzygy's various tools gave better
error messages when asked to process 64-bit binaries. That would have made
investigating this breakage easier: crbug.com/628055—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#47 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABY1F8yMbUTjwGBKvktnrxVkHxdFYD2Bks5qVm_BgaJpZM4JK1TE
.
from syzygy.
hum, it doesn't seem too hard to add a small check in our PE parser , it's probably worth doing this.
from syzygy.
Most of our tools should outright reject 64 bit binaries as they do.
Unfortunately the check is pretty much buried down at the bottom of a stack
of layers, and so the error message is cryptic.
It would make sense to pre-flight all the binaries we handle by testing
their magic and fail with a less cryptic message. After that, you could
consider fixing the base layer to allow 64 bit PE binaries.
On Thu, Jul 14, 2016 at 2:19 PM Sébastien Marchand [email protected]
wrote:
hum, it doesn't seem too hard to add a small check in our PE parser , it's
probably worth doing this.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#47 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABY1F93UUyrXkR5c-MZUs39vz0AAO0CTks5qVn23gaJpZM4JK1TE
.
from syzygy.
Related Issues (20)
- Crash reporting policy code needs refactoring HOT 4
- Symbolization issue in agent_logger
- Security bug in documentation, and old documentation still in use HOT 2
- Update instrumentation instructions for gn HOT 2
- Official win-asan build failing
- ClusterFuzz tripping DCHECKs in SyzyASAN RTL HOT 3
- Consistent shutdown crash on recent canaries.
- syzyasan needs updating to support VS 2017 generated binaries HOT 7
- How SyzyASAN report more errors than just one? HOT 2
- Flaky Test in Syzygy Asan HOT 1
- CRT function replacement failures should be able to fail build HOT 1
- Errant assert in agent::asan::TestMemoryRange?
- Faults in UnhandledExceptionFilter go to WER
- Unable to read SEH handler table. HOT 3
- Errors in instrument usage string
- Instrumentation fails - Unexpected data label at offset HOT 1
- can't compile due to missing python26 dependancy HOT 2
- syzygy has serveral problems in WinSDK 17134 and clang compiler builds project
- Security Policy violation Binary Artifacts HOT 88
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from syzygy.