Bare gits needs to have refs/heads/ included in ref name (go-git.v4?) about zoekt HOT 6 CLOSED

yeah, this could have been the go-git transition. The relevant code would be under gitindex, and there is an option BranchPrefix that should hold refs/heads/ . The prefix should not go into the actual branch name, afaict:

https://gerrit.googlesource.com/zoekt/+/f3e8b54db17ec67f8108123bac197194f51d1288/gitindex/git.go#342

maybe expandBranches doesn't behave as expected?

from zoekt.

Sven made a match which seems to work for us:

https://gerrit-review.googlesource.com/c/zoekt/+/137410

from zoekt.

can you tell me more about the failure mode? I can't reproduce the problem.

$ git clone --mirror https://gerrit.googlesource.com/zoekt
$ cd zoekt.git
$ git show-ref|grep master
e255527 refs/heads/master
$ zoekt-git-index --branches=master .
2017/11/05 14:03:11 finished /home/hanwen/.zoekt/gerrit.googlesource.com_zoekt_v14.00000.zoekt: 1261902 index bytes (overhead 3.4)

from zoekt.

That will work because the default -prefix is "refs/heads/".

Since we index Gerrit configurations (refs/meta/config) we need to set "-prefix" to an empty string or else we cannot index the "refs/meta/"-branches.

Pre go-git.v4 we could set -prefix to "" and it would still find and index a ref like "master". That way we could index both "master" (not "refs/heads/master") and "refs/meta/config", which was perfect for us.

Since go-git.v4, zoekt-git-index wont find "master" anymore with -prefix "", so we have to specify the full branch ref: "refs/heads/master" which clutters the UI (and I guess affect the searches).

I guess people that index refs/notes and similar namespaces will have the same problem.

from zoekt.

This problem is solved by this patch:
https://gerrit-review.googlesource.com/c/zoekt/+/137410

from zoekt.

fixed by e1a95db

from zoekt.