Giter VIP home page Giter VIP logo

Comments (13)

mikeni avatar mikeni commented on May 15, 2024

bump

from google-api-ads-ruby.

mikeni avatar mikeni commented on May 15, 2024

Savon 3.x is about to be released, we should have 2.x by now

from google-api-ads-ruby.

alexcavalli avatar alexcavalli commented on May 15, 2024

+1 to this. Tried patching it myself, but it looks like they're pretty well tied together. Also, it doesn't look like Savon v2 surfaces the HTTPI request objects for service calls anymore, which this gem is using to set up the user agent and some authentication stuff here and here.

from google-api-ads-ruby.

mpatric avatar mpatric commented on May 15, 2024

bump

from google-api-ads-ruby.

subelsky avatar subelsky commented on May 15, 2024

definitely want this

from google-api-ads-ruby.

epchris avatar epchris commented on May 15, 2024

bump 💯

from google-api-ads-ruby.

subelsky avatar subelsky commented on May 15, 2024

this issue is forcing us to lock to a very old version of the gem (and other savon-related gems), which means we're using very deprecated DFP APIs on behalf of our customers. Going to have to write our own versions of all of these gems to get around the problem.

from google-api-ads-ruby.

dklimkin avatar dklimkin commented on May 15, 2024

We're looking closely into this upgrade right now. Unfortunately it is pretty tricky as Savon2 incapsulates parts we're actively working with, while it's still not capable of handling our complex wsdls.

Mike, could you please elaborate on the DFP version issues? The google dfp lib should support the latest DFP API version.

from google-api-ads-ruby.

subelsky avatar subelsky commented on May 15, 2024

Sorry, I confused myself, haven't looked at this issue in awhile. Your use of savon is preventing me from upgrading a bunch of other gems that use newer versions of savon, but that's not blocking me on DFP. I'm locked to an old version of google-dfp-api by another gem that uses an old version of another dependency. Fun times!

from google-api-ads-ruby.

jamiequint avatar jamiequint commented on May 15, 2024

bump

from google-api-ads-ruby.

dcleven avatar dcleven commented on May 15, 2024

Now that Ruby 1.9.3 is officially not being maintained anymore as of 2/24/15, and Savon 1 only supports 1.9.3, and Savon 2 supports Ruby 2, I think this needs to be addressed ASAP.

from google-api-ads-ruby.

mcloonan avatar mcloonan commented on May 15, 2024

Savon 2 does not support the complex AdWords API wsdls. I would love to upgrade and put this to rest, but it isn't feasible at the moment. We are looking into alternatives.

from google-api-ads-ruby.

mcloonan avatar mcloonan commented on May 15, 2024

The newest versions of ads_common and adwords_api no longer have a dependency on Savon, rather depending on our own fork of Savon which should not conflict with newer versions. dfp_api will also pick up this change in its next release. Please open a new issue for any problems with the ads_savon library or other client library issues.

from google-api-ads-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.