Giter VIP home page Giter VIP logo

Comments (3)

hudarsono avatar hudarsono commented on May 14, 2024

After reading the source code, we found that the parameter has been changed from "approval_prompt" to "oauth2_approval_prompt" somewhere in between version. After making that changes, it started working again.
I think it would be good if any change like this is documented as lib migration note.

from google-api-ads-ruby.

mcloonan avatar mcloonan commented on May 14, 2024

What was the last version that this was working on for you? I'm trying to narrow down the specific source of the error.

from google-api-ads-ruby.

mcloonan avatar mcloonan commented on May 14, 2024

Ah, I found the issue.

We never supported :approval_prompt. To set this option from our library, the argument was always :oauth2_approval_prompt. So this means that your setting was getting lost.

However, signet's default setting for :approval_prompt used to be "force", but changed in a recent update to signet that we incorporated into our library. So the default setting happened to be the same as what you wanted, but it's not anymore.

I will look into making 'force' the default action by the client library in a future version; however, this isn't actually a bug and now you're setting the correct attribute, so I'm going to close this issue.

from google-api-ads-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.