Comments (4)
"transitType": {
"enum": [
"TRANSIT_TYPE_UNSPECIFIED",
"BUS",
"bus",
"RAIL",
"rail",
"TRAM",
"tram",
"FERRY",
"ferry",
"OTHER",
"other"
],
"description": "Required. The type of transit this class represents, such as \"bus\".",
"enumDeprecated": [
false,
false,
true,
false,
true,
false,
true,
false,
true,
false,
true
],
"type": "string",
"enumDescriptions": [
"",
"",
"Legacy alias for `BUS`. Deprecated.",
"",
"Legacy alias for `RAIL`. Deprecated.",
"",
"Legacy alias for `TRAM`. Deprecated.",
"",
"Legacy alias for `FERRY`. Deprecated.",
"",
"Legacy alias for `OTHER`. Deprecated."
]
},
... but none of the enums get generated.
We should also add the text descriptions as DocBlocks, would be immensely helpful for anybody using this SDK.
from google-api-php-client-services.
Hello @razvanphp
You're correct in identifying that this library does not generate enums.
This was a feature request in #563, but since this library is essentially in maintenance mode, we made the decision to not merge it.
from google-api-php-client-services.
hey @bshaffer
While I understand this lib is pretty much outdated, the wallterobjects objects were added rather recently, but we cannot add those constants only for this because of the generators.
Isn't there a better way to do this without creating so many files, maybe using phpdoc types at least, so IDEs can alert? This can be done in the same files probably, but I'm not familiar with how the generator works to do it myself.
The use-case is obvious, makes no sense to define those in my lib, while depending on those classes anyway, everybody should use types in 2024, even in PHP ๐
from google-api-php-client-services.
Hi @razvanphp , these are just strings, so extra classes or typing is not necessary. I do think adding these values to phpdoc is something we should look into.
Edit: it seems like there are a lot of options for this, and we should implement one of them.
from google-api-php-client-services.
Related Issues (20)
- chore: update copyright year
- Slow download time impacting our tests. HOT 2
- HangoutsChat - Cannot add user into a space HOT 2
- composer install fails while trying to download "google/apiclient-services" everytime for the last three weeks (duplicate by mistake)
- composer install fails while trying to download "google/apiclient-services" everytime for the last three weeks HOT 6
- Obtain Domains list HOT 1
- Package is difficult to install HOT 1
- User does not have sufficient permissions for this profile. HOT 2
- `ValueRange:getValues()` returns null for empty sheet. HOT 3
- Dynamic property declarations in PHP 8.2 HOT 1
- Method: verificationTokens.generate missing in MyBusinessVerifications HOT 4
- Dynamic property declarations in PHP 8.2 (follow-up) HOT 4
- getResources() now returns null
- Add `@throws \Google\Service\Exception` in method's phpdoc HOT 2
- Safe browsing client refers to non existent v5 version HOT 5
- Hey, Iโve been working with Swoole and I think thereโs an issue when the application runs in a resident memory environment
- Add a script to generate the golden clients from the golden files
- Composed failing to download package HOT 1
- Method: Location get does not return price in serviceItems array
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-api-php-client-services.