Comments (12)
Thanks for reporting this. We are currently using some ES6 features that are compatible with Node 4. I will discuss with the rest of the team whether we can publish ES5-only versions.
from nodejs-firestore.
@stephenplusplus - Do you mind weighing in on this?
from nodejs-firestore.
Related issues:
If the only thing stopping integration with our modules is that we use ES6 (I doubt this is the case, historically, users have run into many quirks), I think the user could probably find an ES6-to-5-ifier that could run during their compilation step.
More generally, we don't offer any direct support for our libraries outside of the conventional Node.js runtime environments. We would need a call from @alexander-fenster if we should reconsider.
from nodejs-firestore.
Is anyone working on this? This is blocking anyone using create-react-app with Firestore.
@mylbp2ps3 did you ever find a fix?
from nodejs-firestore.
Turns out the issue is contained with firebase-admin
- switching from Firestore to Realtime Database (which does not require the firebase-admin
package in Node.js) enables CRA to minify on build.
I am using Realtime Database for now but dissatisfied with this solution because Firestore is the future.
from nodejs-firestore.
Is anyone working on this?
We are not currently working on this, but would appreciate more user feedback.
from nodejs-firestore.
Thanks for the response @schmidt-sebastian! I hope this moves up the priority ladder soon!
from nodejs-firestore.
@mylbp2ps3, @kaiyuanneo et al, I'm able to build without a problem using the same build command cross-env NODE_PATH=src:src/components:src/containers:src/utils react-scripts build
.
OS: Mac High Sierra
Node.js version: 8.9.1
npm version: 5.5.1
npm list react-scripts firebase-admin
├── [email protected]
└── [email protected]
What is your version of react-scripts? Have you been able to reproduce this error on a new CRA app? Also, I tend to have less issues when customizing CRA projects using yarn
instead of npm
, so you may want to try installing and running with yarn
.
from nodejs-firestore.
@mylbp2ps3 did you end up with a solution to this? We have the same exact problem. I know there are listed solutions provided above, but I'm not certain how to take any of those steps. #2 sounds plausible, but I don't even know where to begin with the @Google-Cloud module. I just would really like to get passed this validate.js file that's causing the build to fail.
@willhlaw I created a different CRA app and was able to build it without a problem. However, once I added the files that use the @Google-Cloud module under firestore, it fails.
This is my first time attemping to build a webapp that's dependent on so many modules and I'm pulling my hair out to get out of this one. I need the firestore dependency and going to the RealTime Database is not an option. I'd appreciate anyone's insight.
Thanks in advance.
├── [email protected]
└── [email protected]
from nodejs-firestore.
I'm having exactly the same issue. I installed everything w/in the last month. I should say that everything that I'm writing is all ES6. The admin template I bought was ES5, but I converted the stuff that I use to ES6. I'm also using Babel, so maybe I should except firebase-admin?
Windows 10 Home
node: v8.9.4
"firebase-admin": "^5.12.0",
"react-scripts": "1.1.1",
from nodejs-firestore.
My site has been working fine for a few months and now all of a sudden I can't build it anymore.
Failed to minify the code from this file:
./node_modules/@google-cloud/firestore/src/validate.js:27
I'm also using ES6. Using the Fireadmin template .
Update: Searching around it has to do with the firebase-admin package via this thread.
I had added it to the fireadmin template to add some additional functionality that I ended up not using. I uninstalled the package and the build ran fine. This may not be an option for everyone, but at least you'll know where to start looking.
from nodejs-firestore.
Closing this due to inactivity. Feel free to re-open should this still be an issue.
from nodejs-firestore.
Related Issues (20)
- Value for argument "fieldPath" is not a valid field path when making OR queries HOT 3
- Aggregation queries: "after each" hook for "inequality filter, explicit orderBy, field value cursor" failed HOT 1
- count queries Run outside Transaction: counts 1 document failed HOT 1
- Firestore class: has getAll() method failed HOT 1
- FieldValue.increment() is not working as expected on subfields of a map HOT 3
- Cannot find package '@google-cloud/firestore' imported from /app/server/chunks/2-r5tmKk85.js HOT 2
- Aggregation queries: "after each" hook for "no filter, explicit orderBy, no cursor" failed HOT 1
- Bundle building: "before each" hook for "succeeds when there are no results" failed
- Aggregation queries: "after each" hook for "performs sum that includes NaN" failed
- v1.FirestoreClient batchGetDocuments: invokes batchGetDocuments with closed client failed HOT 11
- Aggregation queries: "after each" hook for "equality filter, explicit orderBy, no cursor" failed
- Block exposing private keys HOT 3
- Firestore class: getAll() supports field mask failed HOT 1
- Query class: can order by FieldPath.documentId() failed HOT 1
- Aggregation queries: "after each" hook for "no filter, explicit orderBy, document reference cursor" failed
- count queries: "after each" hook for "counts 1 document" failed
- Improve read performance by using stale reads HOT 8
- Setting Firestore databaseId HOT 2
- Client initialization: succeeds for DocumentReference.set() failed HOT 1
- count queries using aggregate api: "after each" hook for "counts with startAt, endAt and offset with DocumentReference cursor" failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nodejs-firestore.