Giter VIP home page Giter VIP logo

Comments (10)

jstenback avatar jstenback commented on July 27, 2024

@DanielRyanSmith or @past, any insight into what might be getting in the way here?

from chromium-dashboard.

DanielRyanSmith avatar DanielRyanSmith commented on July 27, 2024

I'll look into this and report back ASAP. Thanks for bringing this up. 🙂

from chromium-dashboard.

DanielRyanSmith avatar DanielRyanSmith commented on July 27, 2024

As for the "Chromium Trial Name" field, the value that needs to be provided is from the origin_trial_feature_name property, which is "MediaPreviewsOptOutPersistent" in this case.

@mfoltzgoogle Is this a deprecation trial? If so, then we have a bug in the form that needs to be fixed, as it should not require a usecounter value for deprecation trials. In this scenario, I would advise the workaround of providing an existing usecounter with a numeric value (e.g. "kOBSOLETE_PageDestruction"), and we will handle your request disregarding that value.

However, if this is not a deprecation trial, we have a separate problem in which we have no way to track usage of the feature. @past might have further opinions on moving forward if that is the case.

from chromium-dashboard.

mfoltzgoogle avatar mfoltzgoogle commented on July 27, 2024

Thank you for the prompt response, those workarounds allowed the form to be submitted 😁

As for the "Chromium Trial Name" field, the value that needs to be provided is from the origin_trial_feature_name

I was using the value from the name field instead; maybe the form could be specific to refer to the origin_trial_feature_name field to avoid future confusion

@mfoltzgoogle Is this a deprecation trial?

Yes, I set this up as a deprecation trial, because it's allowing sites to opt into existing behavior. Once I checked the "deprecation trial" checkbox it allowed me to submit the form with the dummy usecounter.

I'ts a good point that there is not a way to track usage of this trial yet. I can add a custom UMA for that.

from chromium-dashboard.

DanielRyanSmith avatar DanielRyanSmith commented on July 27, 2024

We can see your creation request submission on our side, so the problem has been mitigated. 🙂

Our validation checks on values in Chromium files is a recently-added feature, so your feedback in this situation has been valuable. We'll take steps to make this less confusing in the future.

from chromium-dashboard.

past avatar past commented on July 27, 2024

Sorry for these bumps as we improve these checks Mark and thanks for your patience, much appreciated!

Note that the Intent to Experiment field should also be mandatory (we'll fix that), so you need to request approval from API Owners before we can proceed with the trial.

from chromium-dashboard.

mfoltzgoogle avatar mfoltzgoogle commented on July 27, 2024

The intent to experiement was LGTMed.

https://groups.google.com/a/chromium.org/g/blink-dev/c/f_x-iPGZSPg/m/QB6nATbuBAAJ

from chromium-dashboard.

mfoltzgoogle avatar mfoltzgoogle commented on July 27, 2024

Let me know if there are other steps required.

from chromium-dashboard.

past avatar past commented on July 27, 2024

Thanks for that pointer, I'll follow up in the OT ticket. Let's use this issue for tracking the Chromestatus bug fixing work.

from chromium-dashboard.

DanielRyanSmith avatar DanielRyanSmith commented on July 27, 2024

Deprecation trials are no longer required to provide a usecounter value in the OT creation request form.

from chromium-dashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.