Giter VIP home page Giter VIP logo

Comments (6)

samthor avatar samthor commented on May 16, 2024 1

@Garbee look at @prasadsilva 's comment.

A nice fix is to set them to be position: fixed (why this wasn't part of the spec I have no idea) and fix the related CSS of that. That way they just live in the middle of the screen regardless of viewport and don't care about layout.

from dialog-polyfill.

scloo avatar scloo commented on May 16, 2024

If I remove the 'bottom: 0" from the css for _dialog_overlay ,the dialog becomes available. But it basically disable the modal functionality, making it like the regular dialog without modal.

I have tested your modal demo in Safari and it works fine. I just can't see what I have missed. Unless the fact that I am running under Backbone JS view environment might have complicated the case. But it works without a hitch under Chrome.

from dialog-polyfill.

prasadsilva avatar prasadsilva commented on May 16, 2024

I'm running into this too, but I think on my end the issue is related to the following limitation (per README):

They should be a child of or have parents without layout (aka, no position absolute or relative elements)

I'm using react-mdl, and the dialog elements are being created inside the content section of a page that uses layout to support a responsive header and a navbar.

from dialog-polyfill.

5amfung avatar 5amfung commented on May 16, 2024

I have similar issue with Safari that the modal doesn't close. However hitting the esc key did close the modal.

from dialog-polyfill.

Garbee avatar Garbee commented on May 16, 2024

Ah, interesting. I'll take a look at this on Thursday or Friday if I have time. That sounds like a great fix.

from dialog-polyfill.

samthor avatar samthor commented on May 16, 2024

Closing this as it's related to incorrect use of stacking context. We now warn if you're making a mistake, and also are more permissive, so incorrect usage might still work: #131

from dialog-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.