Comments (6)
@Garbee look at @prasadsilva 's comment.
A nice fix is to set them to be position: fixed
(why this wasn't part of the spec I have no idea) and fix the related CSS of that. That way they just live in the middle of the screen regardless of viewport and don't care about layout.
from dialog-polyfill.
If I remove the 'bottom: 0" from the css for _dialog_overlay ,the dialog becomes available. But it basically disable the modal functionality, making it like the regular dialog without modal.
I have tested your modal demo in Safari and it works fine. I just can't see what I have missed. Unless the fact that I am running under Backbone JS view environment might have complicated the case. But it works without a hitch under Chrome.
from dialog-polyfill.
I'm running into this too, but I think on my end the issue is related to the following limitation (per README):
They should be a child of or have parents without layout (aka, no position absolute or relative elements)
I'm using react-mdl, and the dialog elements are being created inside the content section of a page that uses layout to support a responsive header and a navbar.
from dialog-polyfill.
I have similar issue with Safari that the modal doesn't close. However hitting the esc
key did close the modal.
from dialog-polyfill.
Ah, interesting. I'll take a look at this on Thursday or Friday if I have time. That sounds like a great fix.
from dialog-polyfill.
Closing this as it's related to incorrect use of stacking context. We now warn if you're making a mistake, and also are more permissive, so incorrect usage might still work: #131
from dialog-polyfill.
Related Issues (20)
- backdrop bug with multiple dialogs in safari
- Safari Experimental Feature "Dialog Element" doesn't fire "close" event HOT 3
- Safari 14.0.2 Backdrop and dialog content issue HOT 4
- Too long running function HOT 1
- Safari ignores onclose handler attribute
- Slotted elements which appear within a dialog due to slots but are declared outside of the dialog cannot get focus in Firefox and Safari HOT 2
- Attach css within the script HOT 2
- The "fixed" class no longer positions correctly in Chrome HOT 3
- On Firefox, shows this on console : "Error: Failed to execute 'close' on dialog..." HOT 6
- .
- Polyfill Demo not working in IE11 HOT 1
- Dialog changing from position `absolute` to `fixed`
- Prevent page scrolling while modal dialog is open HOT 3
- BSD is not a valid SPDX License identifier HOT 3
- Consider exporting base class `HTMLDialogElement` for subclassing HOT 2
- No support for imports from isomorphic scripts HOT 3
- Not working in Safari 15.3 HOT 1
- Polyfill injects overlay into <slot> on first render in iOS Safari <15.4 HOT 1
- How to determine if one should load the polyfill
- dialogPolyfill.forceRegisterDialog and browsers with native dialog support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dialog-polyfill.