Giter VIP home page Giter VIP logo

Comments (3)

samthor avatar samthor commented on May 22, 2024 1

Firstly note that ::backdrop doesn't support the polyfill, you'll also need + .backdrop for that. The best practice needs two things-

  • create a div that covers the entire dialog (position: absolute; width: 100%; height: 100%;), remembering to set the dialog to position: relative to contain it
  • add a click handler to the dialog itself

If you see a click on the dialog, i.e. where the event's target is the dialog, you know it must be the backdrop. Otherwise, the event's target would have been the covering div.

from dialog-polyfill.

samthor avatar samthor commented on May 22, 2024

Closing since this is not an issue.

from dialog-polyfill.

mreinstein avatar mreinstein commented on May 22, 2024

a possible alternative approach that doesn't require div tag soup:

when the dialog is opened:

  • attach a click event handler to the body, which takes the event target and traverses up the parentNodes. If a <dialog> element is one of the ancestors, close the dialog

when the dialog is closed:

  • detach the body click event handler

from dialog-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.